Run sample benchmarks on CI (#622)

* Remove LSIF-related benchmarks
sourcegraph · Jul 26, 2023 · 5efa0ff · 5efa0ff
1 parent 9a8200e
commit 5efa0ff
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 20 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,6 +25,19 @@ jobs:
       - name: Main project tests
         run: sbt test
 
+  benchmarks-test:
+    runs-on: ubuntu-latest
+    name: Benchmark tests
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-java@v3
+        with:
+          distribution: "temurin"
+          cache: "sbt"
+          java-version: 17
+      - name: Run sample benchmarks
+        run: sbt 'bench/Jmh/run -i 1 -f1 -t1 -foe true'
+
   docker_test:
     runs-on: ${{ matrix.os }}
     name: Docker CLI tests

diff --git a/tests/benchmarks/src/main/scala/benchmarks/CompileBench.scala b/tests/benchmarks/src/main/scala/benchmarks/CompileBench.scala
@@ -62,7 +62,11 @@ class CompileBench {
   @OutputTimeUnit(TimeUnit.MILLISECONDS)
   def compileSemanticdb(): Long = {
     CompileBench.foreachSource(deps) { inputs =>
-      compiler.compileSemanticdb(inputs).textDocument.getOccurrencesCount
+      compiler
+        .compileSemanticdb(inputs)
+        .textDocument
+        .map(_.getOccurrencesCount)
+        .getOrElse(0)
     }
   }
 
@@ -74,10 +78,9 @@ object CompileBench {
   def foreachSource(
       deps: Dependencies
   )(fn: Seq[Input.VirtualFile] => Int): Long = {
-    var sum = 0L
     deps
       .sources
-      .foreach { source =>
+      .map { source =>
         val path = AbsolutePath(source)
         FileIO.withJarFileSystem(path, create = false, close = true) { root =>
           val files =
@@ -91,9 +94,10 @@ object CompileBench {
             val relativePath = source.toString().stripPrefix("/")
             Input.VirtualFile(relativePath, text)
           }
-          sum += fn(inputs)
+
+          fn(inputs)
         }
       }
-    sum
+      .sum
   }
 }
diff --git a/tests/benchmarks/src/main/scala/benchmarks/ScipSemanticdbBench.scala b/tests/benchmarks/src/main/scala/benchmarks/ScipSemanticdbBench.scala
@@ -48,16 +48,6 @@ class ScipSemanticdbBench {
   @OutputTimeUnit(TimeUnit.MILLISECONDS)
   def json(): Unit = run("index.scip", parallel = false)
 
-  @Benchmark
-  @BenchmarkMode(Array(Mode.SingleShotTime))
-  @OutputTimeUnit(TimeUnit.MILLISECONDS)
-  def protobufParallel(): Unit = run("index.scip-protobuf", parallel = true)
-
-  @Benchmark
-  @BenchmarkMode(Array(Mode.SingleShotTime))
-  @OutputTimeUnit(TimeUnit.MILLISECONDS)
-  def protobuf(): Unit = run("index.scip-protobuf", parallel = false)
-
   private def run(filename: String, parallel: Boolean): Unit = {
     val output = Files.createTempFile("scip-java", filename)
     val parallelFlag =

diff --git a/tests/unit/src/main/scala/tests/CompileResult.scala b/tests/unit/src/main/scala/tests/CompileResult.scala
@@ -8,8 +8,10 @@ case class CompileResult(
     textDocuments: Semanticdb.TextDocuments,
     isSuccess: Boolean
 ) {
-  def textDocument: Semanticdb.TextDocument = {
-    textDocuments.getDocuments(0)
+  def textDocument: Option[Semanticdb.TextDocument] = {
+    Option.when(textDocuments.getDocumentsCount() > 0) {
+      textDocuments.getDocuments(0)
+    }
   }
 
   def merge(other: CompileResult): CompileResult = {

diff --git a/tests/unit/src/test/scala/tests/OverridesSuite.scala b/tests/unit/src/test/scala/tests/OverridesSuite.scala
@@ -26,7 +26,7 @@ class OverridesSuite extends FunSuite with TempDirectories {
       val relativePath = "example.Parent".replace('.', '/') + ".java"
       val input = Input.VirtualFile(relativePath, source)
       val result = compiler.compileSemanticdb(List(input))
-      val symtab = new Symtab(result.textDocument)
+      val symtab = new Symtab(result.textDocument.orNull)
 
       val expectedSyms = expectedSymbols.mkString("\n")
       val syms = symtab

diff --git a/tests/unit/src/test/scala/tests/TargetedSuite.scala b/tests/unit/src/test/scala/tests/TargetedSuite.scala
@@ -44,7 +44,8 @@ class TargetedSuite extends FunSuite with TempDirectories {
           })
           .toList
       val result = compiler.compileSemanticdb(List(input))
-      val occurrences = result.textDocument.getOccurrencesList.asScala.toList
+      val textDocument = result.textDocument.orNull
+      val occurrences = textDocument.getOccurrencesList.asScala.toList
       val symbols: List[String] = positions.map { pos =>
         val posRange = Semanticdb
           .Range
@@ -74,7 +75,7 @@ class TargetedSuite extends FunSuite with TempDirectories {
             )
         }
       }
-      fn(result.textDocument, symbols)
+      fn(textDocument, symbols)
     }
   }