Scoring: test against local scip-ctags #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
commented
Oct 31, 2023
| @@ -835,7 +835,7 @@ func scoreSymbolKind(language string, filename []byte, sym []byte, kind ctags.Sy | |||
| switch kind { | |||
| case ctags.Class: // classes | |||
| factor = 10 | |||
| case ctags.Function: // function definitions | |||
| case ctags.Function, ctags.Method: // function definitions | |||
There was a problem hiding this comment.
Enabling these tests caught a bug in our Python logic: universal-ctags always emits function, but scip-ctags distinguishes between function and method.
keegancsmith
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors our end-to-end scoring tests and enables local testing
using the scip-ctags binary:
e2e_testand into their own filescoring_testTestFileNameMatch,TestJava,TestGo, etc.scip-ctags binary
To run scip-ctags tests locally, you can set the env variable
This doesn't yet update Zoekt CI to run scip-ctags tests. That will be tackled
in a follow-up.