shards: selectRepoSet supports queries which are not wrapped in and #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit which added support for selectRepoSet in List was ineffective since the queries we get for List do not look like (and ...) but instead directly specify the reposet atom. This commit adds support for it. Additionally to help with our manual testing we add support for "repo:" query in the selectRepoSet optimization. While pairing on this we decided to improve the debug output to tracing and rename the misnamed query.Q variable in List from r to q. Test Plan: updated the test case to directly test the sort of queries we get in List calls. Additionally ran "zoekt-webserver -pprof" and observed in net/trace output that selectRepoSet optimization reduced the number of searched shards. Co-authored-by: Stefan Hengl <[email protected]>
stefanhengl
approved these changes
Mar 27, 2024
keegancsmith
added a commit
that referenced
this pull request
Mar 27, 2024
…751) The previous commit which added support for selectRepoSet in List was ineffective since the queries we get for List do not look like (and ...) but instead directly specify the reposet atom. This commit adds support for it. Additionally to help with our manual testing we add support for "repo:" query in the selectRepoSet optimization. While pairing on this we decided to improve the debug output to tracing and rename the misnamed query.Q variable in List from r to q. Test Plan: updated the test case to directly test the sort of queries we get in List calls. Additionally ran "zoekt-webserver -pprof" and observed in net/trace output that selectRepoSet optimization reduced the number of searched shards. Co-authored-by: Stefan Hengl <[email protected]> (cherry picked from commit 7621acc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit which added support for selectRepoSet in List was ineffective since the queries we get for List do not look like (and ...) but instead directly specify the reposet atom.
This commit adds support for it. Additionally to help with our manual testing we add support for "repo:" query in the selectRepoSet optimization.
While pairing on this we decided to improve the debug output to tracing and rename the misnamed query.Q variable in List from r to q.
Test Plan: updated the test case to directly test the sort of queries we get in List calls. Additionally ran "zoekt-webserver -pprof" and observed in net/trace output that selectRepoSet optimization reduced the number of searched shards.