remove SRC_EXPERIMENT_ITERATE_NGRAM_LOOKUP_LIMIT #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After defaulting to shard merging for all inactive repos, this in fact makes searches slightly slower. So we can remove the experiment. Test Plan: go test
|
Fuzz test failed on commit 7dde8b8. To troubleshoot locally, use the GitHub CLI to download the seed corpus with |
This seems to be an infra issue in CI, clicking through to the logs there is a connection timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After defaulting to shard merging for all inactive repos, this in fact makes searches slightly slower. So we can remove the experiment.
Test Plan: go test
Data at https://linear.app/sourcegraph/issue/SPLF-174/turn-off-trigram-limit-experiment-and-see-impact-on-dotcom-perf#comment-46e58236