Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: remove scip-ctags from Dockerfile #802

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

keegancsmith
Copy link
Member

This is an optional dependency that I don't believe OSS users of docker use. We used to use these dockerfiles in Sourcegraph, but have since moved to building it in our own CI with scip-ctags.

Test Plan: built locally

docker build -t zoekt .
docker build -t zoekt-indexserver . -f Dockerfile.indexserver
docker build -t zoekt-webserver   . -f Dockerfile.webserver

This is an optional dependency that I don't believe OSS users of docker
use. We used to use these dockerfiles in Sourcegraph, but have since
moved to building it in our own CI with scip-ctags.

Test Plan: built locally

  docker build -t zoekt .
  docker build -t zoekt-indexserver . -f Dockerfile.indexserver
  docker build -t zoekt-webserver   . -f Dockerfile.webserver
@keegancsmith keegancsmith requested review from jhchabran, varungandhi-src and a team August 7, 2024 06:16
@cla-bot cla-bot bot added the cla-signed label Aug 7, 2024
@keegancsmith
Copy link
Member Author

@sourcegraph/search-platform we should consider making the indexserver docker image instead the zoekt-indexserver binary since this image is no longer used by Sourcegraph. That would be a better service to our OSS users.

@keegancsmith keegancsmith merged commit e77b32d into main Aug 7, 2024
9 checks passed
@keegancsmith keegancsmith deleted the k/rm-scip-ctags-docker branch August 7, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants