Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zoekt-mirror-gitea #844

Merged
merged 3 commits into from
Oct 14, 2024
Merged

add zoekt-mirror-gitea #844

merged 3 commits into from
Oct 14, 2024

Conversation

techknowlogick
Copy link
Contributor

No description provided.

@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 11, 2024

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

keegancsmith
keegancsmith reviewed Oct 12, 2024
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, just need to finish it up and sign the CLA

cmd/zoekt-mirror-gitea/main.go Outdated Show resolved Hide resolved
cmd/zoekt-mirror-gitea/main.go Outdated Show resolved Hide resolved
cmd/zoekt-mirror-gitea/main.go
return err
}
if dest != "" {
fmt.Println(dest)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy/paste from the GitHub mirror code

@techknowlogick
* Clean up setting the default
172be7c 
* update note about topic filtering not being implemented as topics are missing from the API
* cleanup some pointers
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 14, 2024

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

@techknowlogick
Copy link
Contributor Author

@cla-bot, I have already filled out with email address & github username!

@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 14, 2024

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

keegancsmith
keegancsmith approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll check in with others about cla-bot misbehaving.

@keegancsmith keegancsmith merged commit da3626e into sourcegraph:main Oct 14, 2024
8 of 9 checks passed
@keegancsmith
Copy link
Member

I see your CLA entry, the bot got confused with some trailing whitespace in it. Sorting the bot out. Thanks again for your contribution.

@techknowlogick techknowlogick deleted the zoekt-mirror-gitea branch October 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techknowlogick @keegancsmith