-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN Turbo/Fabric migration #88
base: master
Are you sure you want to change the base?
Conversation
@nemanjar7 - Can you pull this sample out down and give it a shot locally? Want to have someone else test to be sure we understand this movement to New Arch |
The logs are intentional since just a sample app to see what's it's doing. The drawing persisting seems odd - I'd like @ian-wd to comment on that. |
ill check this weekend, I haven't encountered that I'm mostly running this on android |
Fixed iOS fabric view/sketchcanvas cleanup ios-cleanup-fix.mp4 |
.github/workflows/publish.yml
Outdated
run: npm publish --access public | ||
run: yarn npm publish --access public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefixing yarn in front of an npm command seems odd
Pull Request: react-native-sketch-canvas
Description
Turbo/Fabric View migration
Type of Change
Testing Performed
Test Results
Breaking Changes