Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using standardized MultiCollection if/when it exists #108

Open
bluegenes opened this issue Oct 4, 2024 · 0 comments
Open

consider using standardized MultiCollection if/when it exists #108

bluegenes opened this issue Oct 4, 2024 · 0 comments

Comments

@bluegenes
Copy link
Collaborator

#102 introduces a light MultiCollection for storing multiple Collections. The implementation here is very lightweight, and is only used to:

  1. load from existing zipfiles (prior batches that succeeded)
  2. iterate across these existing sigs to build a Hashmap of BuildParams that can be used to filter out any template signatures that already exist in the batched zips.

If MultiCollection from branchwater (sourmash-bio/sourmash_plugin_branchwater#430) gets standardized and introduced into sourmash core, we could likely use that here instead. However, we would still need to have a buildparams_hashmap implementation.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant