Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install package to work with custom download_checksum #795

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

tschroeder-zendesk
Copy link
Contributor

@tschroeder-zendesk tschroeder-zendesk commented Dec 19, 2023

Description

Fix install package to work with custom download_checksum. Currently you cannot specify the download_url or download_checksum so you cannot install newer versions then what already exists!

Issues Resolved

List any existing issues this PR resolves

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@tschroeder-zendesk tschroeder-zendesk requested a review from a team as a code owner December 19, 2023 12:49
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog for this change please?

We'll be able to release that as soon as that's done 👍🏼

@tschroeder-zendesk
Copy link
Contributor Author

Fixed so testing works and cookbook works with or without url/checksum defined. It seems new_resource doesn't exist for download_url or download_checksum unless they are defined, so it uses the old code when they are indeed undefined. This allows for actual override instead of getting an error of "Unsupported version" when you define for example just a download_checksum or both as that was a non-working case prior to this change.

@tschroeder-zendesk
Copy link
Contributor Author

Okay... so finally found the root of the real issue. It was referencing the values in the defaults incorrectly causing issues. It also should be using new_resource always for the install_package. I have tested this with a bunch of value combinations and it should be good to go now.

@damacus damacus added the Release: Patch Release to Chef Supermarket as a version patch when merged label Dec 27, 2023
@damacus damacus merged commit b5e7e92 into sous-chefs:main Dec 27, 2023
27 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 5.1.10

@damacus
Copy link
Member

damacus commented Dec 27, 2023

Excellent, thank you!

@tschroeder-zendesk tschroeder-zendesk deleted the patch-1 branch December 28, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Patch Release to Chef Supermarket as a version patch when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants