Raise UnsupportedSyntax if a proc object is given as block-pass-argument #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
type_construction/proc_for_block_pass_argument
branch
3 times, most recently
from
44ace21 to
ca398f1
Compare
tk0miya
commented
Oct 2, 2024
| @@ -4191,6 +4191,16 @@ def try_method_type(node, receiver_type:, method_name:, method_overload:, argume | |||
| ) | |||
| else | |||
| # non-nil value is given | |||
| if node_type.is_a?(AST::Types::Name::Instance) && node_type.name.to_s == '::Proc' | |||
There was a problem hiding this comment.
Is it better to move this into #synthesize?
At present, users will see BlockTypeMismatch diagnostic when a proc object is passed as block-pass-argument. We'll usually see the diagnostic with `&method` idiom. ```ruby [1, 2, 3].map(&method(:puts)) ``` But there is nothing to do from the user side because such a call is not invalid. It seems like a false positive. This changes the diagnostic type for the case to UnsupportedSyntax. It notifies users that the source code is valid and that change is unnecessary. refs: soutaro#149
tk0miya
force-pushed
the
type_construction/proc_for_block_pass_argument
branch
from
ca398f1 to
3271811
Compare
|
Now, #1276 has been merged into the master. But this is still needed, I believe. For example, the following code will cause the diagnostic: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, users will see BlockTypeMismatch diagnostic when a proc object is passed as block-pass-argument. We'll usually see the diagnostic with
&methodidiom.But there is nothing to do from the user side because such a call is not invalid. It seems like a false positive.
This changes the diagnostic type for the case to UnsupportedSyntax. It notifies users that the source code is valid and that change is unnecessary.
refs: #149