Use generator for get_all_serial #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_all_serial is used to iterate through a paginated response from shipwire's API. Previously it would add each batch of items to a list and then return that list once there were no more results to get. This changes get_all_serial to be a generator, so that the program only has to keep a single batch's worth of items in memory at a time. This is especially helpful for grabbing large datasets from shipwire, because you can begin processing items from shipwire while there are still items to be requested.
copperwall
force-pushed
the
use-generator-for-get-all-serial
branch
from
ae85f12 to
c3b7e7a
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_all_serialis used to iterate through a paginated response fromshipwire's API. Previously it would add each batch of items to a list
and then return that list once there were no more results to get.
This changes get_all_serial to be a generator, so that the program only
has to keep a single batch's worth of items in memory at a time. This is
especially helpful for grabbing large datasets from shipwire, because
you can begin processing resource items from shipwire while there are still items
to be fetched.