warning: useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>` --> crates/cmds-solana/src/jupiter/swap.rs:113:23 | 113 | instructions: instructions.into(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `instructions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: casting to the same type is unnecessary (`u16` -> `u16`) --> crates/cmds-solana/src/jupiter/swap.rs:76:38 | 76 | quote_request.slippage_bps = slippage_percent as u16 * 100; | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `slippage_percent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>` --> crates/cmds-solana/src/jupiter/swap.rs:113:23 | 113 | instructions: instructions.into(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `instructions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: casting to the same type is unnecessary (`u16` -> `u16`) --> crates/cmds-solana/src/jupiter/swap.rs:76:38 | 76 | quote_request.slippage_bps = slippage_percent as u16 * 100; | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `slippage_percent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:46:65 | 46 | pub fn ui_amount_to_amount(ui_amount: Decimal, decimals: u8) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:34:44 | 34 | pub fn sol_to_lamports(amount: Decimal) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:46:65 | 46 | pub fn ui_amount_to_amount(ui_amount: Decimal, decimals: u8) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:34:44 | 34 | pub fn sol_to_lamports(amount: Decimal) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/nft/arweave_nft_upload.rs:186:10 | 186 | ) -> crate::Result<Uploader> { | ^^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/nft/arweave_nft_upload.rs:186:10 | 186 | ) -> crate::Result<Uploader> { | ^^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/generate_keypair.rs:39:54 | 39 | fn generate_keypair(passphrase: &str, seed: &str) -> crate::Result<Keypair> { | ^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default

warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/generate_keypair.rs:39:54 | 39 | fn generate_keypair(passphrase: &str, seed: &str) -> crate::Result<Keypair> { | ^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1235:25 | 1235 | public_key: pubkey.clone(), | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1216:40 | 1216 | let x = WalletOrPubkey::Pubkey(pubkey.clone()); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1201:25 | 1201 | public_key: pubkey.clone(), | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:94:51 | 94 | Wallet::Adapter { public_key, .. } => public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:80:29 | 80 | public_key: public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:94:51 | 94 | Wallet::Adapter { public_key, .. } => public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:80:29 | 80 | public_key: public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: match can be simplified with `.unwrap_or_default()` --> crates/space-wasm/src/ffi.rs:85:5 | 85 | / match stub(ctx, bytes, bytes_len) { 86 | | Ok(pointer) => pointer, 87 | | _ => 0, 88 | | } | |_____^ help: replace it with: `stub(ctx, bytes, bytes_len).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default

warning: match can be simplified with `.unwrap_or_default()` --> crates/space-wasm/src/ffi.rs:85:5 | 85 | / match stub(ctx, bytes, bytes_len) { 86 | | Ok(pointer) => pointer, 87 | | _ => 0, 88 | | } | |_____^ help: replace it with: `stub(ctx, bytes, bytes_len).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:628:26 | 628 | fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 628 - fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { 628 + fn to_custom_decimal(d: &Decimal) -> CustomDecimal<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:491:17 | 491 | / Ok(seq 492 | | .next_element()? 493 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 491 ~ seq 492 + .next_element()? 493 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:392:28 | 392 | fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 392 - fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { 392 + fn to_custom_signature(pk: &Signature) -> CustomSignature<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:376:17 | 376 | / Ok(seq 377 | | .next_element()? 378 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 376 ~ seq 377 + .next_element()? 378 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:263:25 | 263 | fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 263 - fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { 263 + fn to_custom_pubkey(pk: &Pubkey) -> CustomPubkey<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:167:29 | 167 | / ... Ok(seq 168 | | ... .next_element()? 169 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 167 ~ seq 168 + .next_element()? 169 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:158:25 | 158 | / Ok(seq 159 | | .next_element()? 160 | | .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 158 ~ seq 159 + .next_element()? 160 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:147:29 | 147 | / ... Ok(seq 148 | | ... .next_element()? 149 | | ... .ok_or_else(|| de::Error::invalid_length(i + 32, &"64"))?) | |____________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 147 ~ seq 148 + .next_element()? 149 + .ok_or_else(|| de::Error::invalid_length(i + 32, &"64")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:137:29 | 137 | / ... Ok(seq 138 | | ... .next_element()? 139 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default help: try removing question mark and `Ok()` | 137 ~ seq 138 + .next_element()? 139 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:628:26 | 628 | fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 628 - fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { 628 + fn to_custom_decimal(d: &Decimal) -> CustomDecimal<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:491:17 | 491 | / Ok(seq 492 | | .next_element()? 493 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 491 ~ seq 492 + .next_element()? 493 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:392:28 | 392 | fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 392 - fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { 392 + fn to_custom_signature(pk: &Signature) -> CustomSignature<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:376:17 | 376 | / Ok(seq 377 | | .next_element()? 378 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 376 ~ seq 377 + .next_element()? 378 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:263:25 | 263 | fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 263 - fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { 263 + fn to_custom_pubkey(pk: &Pubkey) -> CustomPubkey<'_> { |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:167:29 | 167 | / ... Ok(seq 168 | | ... .next_element()? 169 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 167 ~ seq 168 + .next_element()? 169 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:158:25 | 158 | / Ok(seq 159 | | .next_element()? 160 | | .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 158 ~ seq 159 + .next_element()? 160 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:147:29 | 147 | / ... Ok(seq 148 | | ... .next_element()? 149 | | ... .ok_or_else(|| de::Error::invalid_length(i + 32, &"64"))?) | |____________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 147 ~ seq 148 + .next_element()? 149 + .ok_or_else(|| de::Error::invalid_length(i + 32, &"64")) |

warning: question mark operator is useless here --> lib/flow-value/src/with.rs:137:29 | 137 | / ... Ok(seq 138 | | ... .next_element()? 139 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default help: try removing question mark and `Ok()` | 137 ~ seq 138 + .next_element()? 139 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |

warning: this `.find_map` can be written more simply using `.map(..).next()` --> crates/srpc/src/lib.rs:162:9 | 162 | / self.transport.iter().find_map(|t| match t { 163 | | Transport::Http { port, .. } => { 164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap()) 165 | | } 166 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map = note: `#[warn(clippy::unnecessary_find_map)]` on by default

warning: this `.find_map` can be written more simply using `.map(..).next()` --> crates/srpc/src/lib.rs:162:9 | 162 | / self.transport.iter().find_map(|t| match t { 163 | | Transport::Http { port, .. } => { 164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap()) 165 | | } 166 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map = note: `#[warn(clippy::unnecessary_find_map)]` on by default

warning: use of deprecated constant `keypair::tests::test_serialize` --> lib/flow-value/src/keypair.rs:58:5 | 58 | / fn test_serialize() { 59 | | let k = Keypair::new(); 60 | | assert_eq!( 61 | | serialize(&k, crate::ser::Serializer).unwrap(), 62 | | Value::B64(k.to_bytes()), 63 | | ) 64 | | } | |_____^

warning: use of deprecated constant `keypair::tests::test_enum` --> lib/flow-value/src/keypair.rs:67:5 | 67 | / fn test_enum() { 68 | | let key = Keypair::new(); 69 | | 70 | | #[derive(serde::Deserialize, PartialEq, Debug)] ... | 91 | | ); 92 | | } | |_____^