Skip to content

check node input and output #109

check node input and output

check node input and output #109

Triggered via pull request November 23, 2024 03:40
Status Failure
Total duration 3m 11s
Artifacts

deps.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 52 warnings
Rust deps
Process completed with exit code 101.
non-exhaustive patterns: `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered: crates/flow-server/src/db_worker/user_worker.rs#L493
error[E0004]: non-exhaustive patterns: `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered --> crates/flow-server/src/db_worker/user_worker.rs:493:58 | 493 | flow::Error::BuildGraphError(e) => match e { | ^ patterns `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered | note: `flow::flow_graph::BuildGraphError` defined here --> /home/d/runners/flow-backend/_work/flow-backend/flow-backend/crates/flow/src/flow_graph.rs:356:1 | 356 | pub enum BuildGraphError { | ^^^^^^^^^^^^^^^^^^^^^^^^ ... 364 | NoInput((NodeId, String)), | ------- not covered 365 | #[error("node {:?} has no output {:?}", .0.0, .0.1)] 366 | NoOutput((NodeId, String)), | -------- not covered = note: the matched value is of type `&flow::flow_graph::BuildGraphError` help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms | 500 ~ }, 501 + &flow::flow_graph::BuildGraphError::NoInput(_) | &flow::flow_graph::BuildGraphError::NoOutput(_) => todo!() |
non-exhaustive patterns: `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered: crates/flow-server/src/db_worker/user_worker.rs#L493
error[E0004]: non-exhaustive patterns: `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered --> crates/flow-server/src/db_worker/user_worker.rs:493:58 | 493 | flow::Error::BuildGraphError(e) => match e { | ^ patterns `&flow::flow_graph::BuildGraphError::NoInput(_)` and `&flow::flow_graph::BuildGraphError::NoOutput(_)` not covered | note: `flow::flow_graph::BuildGraphError` defined here --> /home/d/runners/flow-backend/_work/flow-backend/flow-backend/crates/flow/src/flow_graph.rs:356:1 | 356 | pub enum BuildGraphError { | ^^^^^^^^^^^^^^^^^^^^^^^^ ... 364 | NoInput((NodeId, String)), | ------- not covered 365 | #[error("node {:?} has no output {:?}", .0.0, .0.1)] 366 | NoOutput((NodeId, String)), | -------- not covered = note: the matched value is of type `&flow::flow_graph::BuildGraphError` help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms | 500 ~ }, 501 + &flow::flow_graph::BuildGraphError::NoInput(_) | &flow::flow_graph::BuildGraphError::NoOutput(_) => todo!() |
Rust deps
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust deps
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust deps
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust deps
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust deps
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust deps
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>`: crates/cmds-solana/src/jupiter/swap.rs#L114
warning: useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>` --> crates/cmds-solana/src/jupiter/swap.rs:114:23 | 114 | instructions: instructions.into(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `instructions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
casting to the same type is unnecessary (`u16` -> `u16`): crates/cmds-solana/src/jupiter/swap.rs#L76
warning: casting to the same type is unnecessary (`u16` -> `u16`) --> crates/cmds-solana/src/jupiter/swap.rs:76:38 | 76 | quote_request.slippage_bps = slippage_percent as u16 * 100; | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `slippage_percent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>`: crates/cmds-solana/src/jupiter/swap.rs#L114
warning: useless conversion to the same type: `std::vec::Vec<solana_sdk::instruction::Instruction>` --> crates/cmds-solana/src/jupiter/swap.rs:114:23 | 114 | instructions: instructions.into(), | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `instructions` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
casting to the same type is unnecessary (`u16` -> `u16`): crates/cmds-solana/src/jupiter/swap.rs#L76
warning: casting to the same type is unnecessary (`u16` -> `u16`) --> crates/cmds-solana/src/jupiter/swap.rs:76:38 | 76 | quote_request.slippage_bps = slippage_percent as u16 * 100; | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `slippage_percent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/utils.rs#L46
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:46:65 | 46 | pub fn ui_amount_to_amount(ui_amount: Decimal, decimals: u8) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/utils.rs#L34
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:34:44 | 34 | pub fn sol_to_lamports(amount: Decimal) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/utils.rs#L46
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:46:65 | 46 | pub fn ui_amount_to_amount(ui_amount: Decimal, decimals: u8) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/utils.rs#L34
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/utils.rs:34:44 | 34 | pub fn sol_to_lamports(amount: Decimal) -> crate::Result<u64> { | ^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/nft/arweave_nft_upload.rs#L186
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/nft/arweave_nft_upload.rs:186:10 | 186 | ) -> crate::Result<Uploader> { | ^^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/generate_keypair.rs#L39
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/generate_keypair.rs:39:54 | 39 | fn generate_keypair(passphrase: &str, seed: &str) -> crate::Result<Keypair> { | ^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/nft/arweave_nft_upload.rs#L186
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/nft/arweave_nft_upload.rs:186:10 | 186 | ) -> crate::Result<Uploader> { | ^^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
the `Err`-variant returned from this function is very large: crates/cmds-solana/src/generate_keypair.rs#L39
warning: the `Err`-variant returned from this function is very large --> crates/cmds-solana/src/generate_keypair.rs:39:54 | 39 | fn generate_keypair(passphrase: &str, seed: &str) -> crate::Result<Keypair> { | ^^^^^^^^^^^^^^^^^^^^^^ | ::: crates/cmds-solana/src/error.rs:14:5 | 14 | SolanaClient(#[from] solana_client::client_error::ClientError), | -------------------------------------------------------------- the largest variant contains at least 224 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L1303
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1303:25 | 1303 | public_key: pubkey.clone(), | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L1284
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1284:40 | 1284 | let x = WalletOrPubkey::Pubkey(pubkey.clone()); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L1269
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:1269:25 | 1269 | public_key: pubkey.clone(), | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: lib/flow-lib/src/solana.rs#L569
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> lib/flow-lib/src/solana.rs:569:18 | 569 | .zip(signers.pubkeys().into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `signers.pubkeys()` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/iter/traits/iterator.rs:598:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: lib/flow-lib/src/solana.rs#L569
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> lib/flow-lib/src/solana.rs:569:18 | 569 | .zip(signers.pubkeys().into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `signers.pubkeys()` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/iter/traits/iterator.rs:598:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L102
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:102:51 | 102 | Wallet::Adapter { public_key, .. } => public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L88
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:88:29 | 88 | public_key: public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L102
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:102:51 | 102 | Wallet::Adapter { public_key, .. } => public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Pubkey` which implements the `Copy` trait: lib/flow-lib/src/solana.rs#L88
warning: using `clone` on type `Pubkey` which implements the `Copy` trait --> lib/flow-lib/src/solana.rs:88:29 | 88 | public_key: public_key.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
match can be simplified with `.unwrap_or_default()`: crates/space-wasm/src/ffi.rs#L85
warning: match can be simplified with `.unwrap_or_default()` --> crates/space-wasm/src/ffi.rs:85:5 | 85 | / match stub(ctx, bytes, bytes_len) { 86 | | Ok(pointer) => pointer, 87 | | _ => 0, 88 | | } | |_____^ help: replace it with: `stub(ctx, bytes, bytes_len).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
match can be simplified with `.unwrap_or_default()`: crates/space-wasm/src/ffi.rs#L85
warning: match can be simplified with `.unwrap_or_default()` --> crates/space-wasm/src/ffi.rs:85:5 | 85 | / match stub(ctx, bytes, bytes_len) { 86 | | Ok(pointer) => pointer, 87 | | _ => 0, 88 | | } | |_____^ help: replace it with: `stub(ctx, bytes, bytes_len).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L628
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:628:26 | 628 | fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 628 - fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { 628 + fn to_custom_decimal(d: &Decimal) -> CustomDecimal<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L491
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:491:17 | 491 | / Ok(seq 492 | | .next_element()? 493 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 491 ~ seq 492 + .next_element()? 493 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L392
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:392:28 | 392 | fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 392 - fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { 392 + fn to_custom_signature(pk: &Signature) -> CustomSignature<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L376
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:376:17 | 376 | / Ok(seq 377 | | .next_element()? 378 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 376 ~ seq 377 + .next_element()? 378 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L263
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:263:25 | 263 | fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 263 - fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { 263 + fn to_custom_pubkey(pk: &Pubkey) -> CustomPubkey<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L167
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:167:29 | 167 | / ... Ok(seq 168 | | ... .next_element()? 169 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 167 ~ seq 168 + .next_element()? 169 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L158
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:158:25 | 158 | / Ok(seq 159 | | .next_element()? 160 | | .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 158 ~ seq 159 + .next_element()? 160 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L147
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:147:29 | 147 | / ... Ok(seq 148 | | ... .next_element()? 149 | | ... .ok_or_else(|| de::Error::invalid_length(i + 32, &"64"))?) | |____________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 147 ~ seq 148 + .next_element()? 149 + .ok_or_else(|| de::Error::invalid_length(i + 32, &"64")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L137
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:137:29 | 137 | / ... Ok(seq 138 | | ... .next_element()? 139 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default help: try removing question mark and `Ok()` | 137 ~ seq 138 + .next_element()? 139 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L628
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:628:26 | 628 | fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 628 - fn to_custom_decimal<'a>(d: &'a Decimal) -> CustomDecimal<'a> { 628 + fn to_custom_decimal(d: &Decimal) -> CustomDecimal<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L491
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:491:17 | 491 | / Ok(seq 492 | | .next_element()? 493 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 491 ~ seq 492 + .next_element()? 493 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L392
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:392:28 | 392 | fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 392 - fn to_custom_signature<'a>(pk: &'a Signature) -> CustomSignature<'a> { 392 + fn to_custom_signature(pk: &Signature) -> CustomSignature<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L376
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:376:17 | 376 | / Ok(seq 377 | | .next_element()? 378 | | .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 376 ~ seq 377 + .next_element()? 378 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
the following explicit lifetimes could be elided: 'a: lib/flow-value/src/with.rs#L263
warning: the following explicit lifetimes could be elided: 'a --> lib/flow-value/src/with.rs:263:25 | 263 | fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 263 - fn to_custom_pubkey<'a>(pk: &'a Pubkey) -> CustomPubkey<'a> { 263 + fn to_custom_pubkey(pk: &Pubkey) -> CustomPubkey<'_> { |
question mark operator is useless here: lib/flow-value/src/with.rs#L167
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:167:29 | 167 | / ... Ok(seq 168 | | ... .next_element()? 169 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"64"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 167 ~ seq 168 + .next_element()? 169 + .ok_or_else(|| de::Error::invalid_length(i, &"64")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L158
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:158:25 | 158 | / Ok(seq 159 | | .next_element()? 160 | | .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 158 ~ seq 159 + .next_element()? 160 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L147
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:147:29 | 147 | / ... Ok(seq 148 | | ... .next_element()? 149 | | ... .ok_or_else(|| de::Error::invalid_length(i + 32, &"64"))?) | |____________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 147 ~ seq 148 + .next_element()? 149 + .ok_or_else(|| de::Error::invalid_length(i + 32, &"64")) |
question mark operator is useless here: lib/flow-value/src/with.rs#L137
warning: question mark operator is useless here --> lib/flow-value/src/with.rs:137:29 | 137 | / ... Ok(seq 138 | | ... .next_element()? 139 | | ... .ok_or_else(|| de::Error::invalid_length(i, &"32"))?) | |_______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default help: try removing question mark and `Ok()` | 137 ~ seq 138 + .next_element()? 139 + .ok_or_else(|| de::Error::invalid_length(i, &"32")) |
this `.find_map` can be written more simply using `.map(..).next()`: crates/srpc/src/lib.rs#L162
warning: this `.find_map` can be written more simply using `.map(..).next()` --> crates/srpc/src/lib.rs:162:9 | 162 | / self.transport.iter().find_map(|t| match t { 163 | | Transport::Http { port, .. } => { 164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap()) 165 | | } 166 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map = note: `#[warn(clippy::unnecessary_find_map)]` on by default
this `.find_map` can be written more simply using `.map(..).next()`: crates/srpc/src/lib.rs#L162
warning: this `.find_map` can be written more simply using `.map(..).next()` --> crates/srpc/src/lib.rs:162:9 | 162 | / self.transport.iter().find_map(|t| match t { 163 | | Transport::Http { port, .. } => { 164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap()) 165 | | } 166 | | }) | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map = note: `#[warn(clippy::unnecessary_find_map)]` on by default
use of deprecated constant `keypair::tests::test_serialize`: lib/flow-value/src/keypair.rs#L58
warning: use of deprecated constant `keypair::tests::test_serialize` --> lib/flow-value/src/keypair.rs:58:5 | 58 | / fn test_serialize() { 59 | | let k = Keypair::new(); 60 | | assert_eq!( 61 | | serialize(&k, crate::ser::Serializer).unwrap(), 62 | | Value::B64(k.to_bytes()), 63 | | ) 64 | | } | |_____^
use of deprecated constant `keypair::tests::test_enum`: lib/flow-value/src/keypair.rs#L67
warning: use of deprecated constant `keypair::tests::test_enum` --> lib/flow-value/src/keypair.rs:67:5 | 67 | / fn test_enum() { 68 | | let key = Keypair::new(); 69 | | 70 | | #[derive(serde::Deserialize, PartialEq, Debug)] ... | 91 | | ); 92 | | } | |_____^
use of deprecated constant `keypair::tests::test_deserialize_value`: lib/flow-value/src/keypair.rs#L51
warning: use of deprecated constant `keypair::tests::test_deserialize_value` --> lib/flow-value/src/keypair.rs:51:5 | 51 | / fn test_deserialize_value() { 52 | | let k = Keypair::new(); 53 | | assert_eq!(de(Value::B64(k.to_bytes())), k); 54 | | assert_eq!(de(Value::String(k.to_base58_string())), k); 55 | | } | |_____^ | = note: `#[warn(deprecated)]` on by default