Flow Deployment #429
docker.yaml
on: pull_request
Build docker image
2m 55s
Integration Test
2m 10s
Annotations
17 warnings
this expression creates a reference which is immediately dereferenced by the compiler:
crates/db/src/connection/conn_impl.rs#L245
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/db/src/connection/conn_impl.rs:245:43
|
245 | self.new_flow_run(config, inputs, &deployment_id).await
| ^^^^^^^^^^^^^^ help: change this to: `deployment_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
crates/db/src/connection/conn_impl.rs#L245
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/db/src/connection/conn_impl.rs:245:43
|
245 | self.new_flow_run(config, inputs, &deployment_id).await
| ^^^^^^^^^^^^^^ help: change this to: `deployment_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this `.find_map` can be written more simply:
crates/srpc/src/lib.rs#L162
warning: this `.find_map` can be written more simply
--> crates/srpc/src/lib.rs:162:9
|
162 | / self.transport.iter().find_map(|t| match t {
163 | | Transport::Http { port, .. } => {
164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap())
165 | | }
166 | | })
| |__________^ help: try instead: `map(..).next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map
= note: `#[warn(clippy::unnecessary_find_map)]` on by default
|
this `.find_map` can be written more simply:
crates/srpc/src/lib.rs#L162
warning: this `.find_map` can be written more simply
--> crates/srpc/src/lib.rs:162:9
|
162 | / self.transport.iter().find_map(|t| match t {
163 | | Transport::Http { port, .. } => {
164 | | Some(Url::parse(&format!("http://127.0.0.1:{}", port)).unwrap())
165 | | }
166 | | })
| |__________^ help: try instead: `map(..).next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map
= note: `#[warn(clippy::unnecessary_find_map)]` on by default
|
use of deprecated constant `keypair::tests::test_serialize`:
lib/flow-value/src/keypair.rs#L58
warning: use of deprecated constant `keypair::tests::test_serialize`
--> lib/flow-value/src/keypair.rs:58:5
|
58 | / fn test_serialize() {
59 | | let k = Keypair::new();
60 | | assert_eq!(
61 | | serialize(&k, crate::ser::Serializer).unwrap(),
62 | | Value::B64(k.to_bytes()),
63 | | )
64 | | }
| |_____^
|
use of deprecated constant `keypair::tests::test_enum`:
lib/flow-value/src/keypair.rs#L67
warning: use of deprecated constant `keypair::tests::test_enum`
--> lib/flow-value/src/keypair.rs:67:5
|
67 | / fn test_enum() {
68 | | let key = Keypair::new();
69 | |
70 | | #[derive(serde::Deserialize, PartialEq, Debug)]
... |
91 | | );
92 | | }
| |_____^
|
use of deprecated constant `keypair::tests::test_deserialize_value`:
lib/flow-value/src/keypair.rs#L51
warning: use of deprecated constant `keypair::tests::test_deserialize_value`
--> lib/flow-value/src/keypair.rs:51:5
|
51 | / fn test_deserialize_value() {
52 | | let k = Keypair::new();
53 | | assert_eq!(de(Value::B64(k.to_bytes())), k);
54 | | assert_eq!(de(Value::String(k.to_base58_string())), k);
55 | | }
| |_____^
|
= note: `#[warn(deprecated)]` on by default
|
the following explicit lifetimes could be elided: 'a:
crates/utils/src/serde_bs58.rs#L41
warning: the following explicit lifetimes could be elided: 'a
--> crates/utils/src/serde_bs58.rs:41:10
|
41 | impl<'a> serde::Serialize for Bs58<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
41 - impl<'a> serde::Serialize for Bs58<'a> {
41 + impl serde::Serialize for Bs58<'_> {
|
|
the following explicit lifetimes could be elided: 'de:
crates/utils/src/serde_bs58.rs#L10
warning: the following explicit lifetimes could be elided: 'de
--> crates/utils/src/serde_bs58.rs:10:6
|
10 | impl<'de, const N: usize> serde::de::Visitor<'de> for Visitor<N> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
10 - impl<'de, const N: usize> serde::de::Visitor<'de> for Visitor<N> {
10 + impl<const N: usize> serde::de::Visitor<'_> for Visitor<N> {
|
|
the following explicit lifetimes could be elided: 'de:
crates/utils/src/serde_base64.rs#L12
warning: the following explicit lifetimes could be elided: 'de
--> crates/utils/src/serde_base64.rs:12:6
|
12 | impl<'de> serde::de::Visitor<'de> for Visitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
12 - impl<'de> serde::de::Visitor<'de> for Visitor {
12 + impl serde::de::Visitor<'_> for Visitor {
|
|
the following explicit lifetimes could be elided: 'a:
crates/utils/src/serde_bs58.rs#L41
warning: the following explicit lifetimes could be elided: 'a
--> crates/utils/src/serde_bs58.rs:41:10
|
41 | impl<'a> serde::Serialize for Bs58<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
41 - impl<'a> serde::Serialize for Bs58<'a> {
41 + impl serde::Serialize for Bs58<'_> {
|
|
the following explicit lifetimes could be elided: 'de:
crates/utils/src/serde_bs58.rs#L10
warning: the following explicit lifetimes could be elided: 'de
--> crates/utils/src/serde_bs58.rs:10:6
|
10 | impl<'de, const N: usize> serde::de::Visitor<'de> for Visitor<N> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
10 - impl<'de, const N: usize> serde::de::Visitor<'de> for Visitor<N> {
10 + impl<const N: usize> serde::de::Visitor<'_> for Visitor<N> {
|
|
the following explicit lifetimes could be elided: 'de:
crates/utils/src/serde_base64.rs#L12
warning: the following explicit lifetimes could be elided: 'de
--> crates/utils/src/serde_base64.rs:12:6
|
12 | impl<'de> serde::de::Visitor<'de> for Visitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
12 - impl<'de> serde::de::Visitor<'de> for Visitor {
12 + impl serde::de::Visitor<'_> for Visitor {
|
|
Integration Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Integration Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Integration Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Integration Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|