warning: manual implementation of `Option::map` --> crates/flow-server/src/main.rs:129:20 | 129 | let auth = if let Some(supabase_auth) = &supabase_auth { | ____________________^ 130 | | Some( 131 | | web::scope("/auth") 132 | | .app_data(web::Data::new(sig_auth)) ... | 139 | | None 140 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default help: try | 129 ~ let auth = supabase_auth.as_ref().map(|supabase_auth| web::scope("/auth") 130 + .app_data(web::Data::new(sig_auth)) 131 + .app_data(web::Data::new(supabase_auth.clone())) 132 + .service(api::claim_token::service(&config, db.clone())) 133 + .service(api::init_auth::service(&config)) 134 ~ .service(api::confirm_auth::service(&config))); |

warning: unnecessary closure used to substitute value for `Option::None` --> crates/flow-server/src/user.rs:202:27 | 202 | let service_key = config | ___________________________^ 203 | | .service_key 204 | | .as_ref() 205 | | .ok_or_else(|| "need service_key")?; | |______________--------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or("need service_key")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default

warning: a `const` item should never be interior mutable --> crates/flow-server/src/middleware/auth.rs:30:1 | 30 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key"); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default

warning: unnecessary closure used to substitute value for `Option::None` --> crates/flow-server/src/user.rs:202:27 | 202 | let service_key = config | ___________________________^ 203 | | .service_key 204 | | .as_ref() 205 | | .ok_or_else(|| "need service_key")?; | |______________--------------------------------^ | | | help: use `ok_or(..)` instead: `ok_or("need service_key")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default

warning: useless conversion to the same type: `serde_json::Value` --> crates/flow-server/src/db_worker/signer.rs:143:29 | 143 | Ok((signer.start(), signers_info.into())) | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `signers_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: a `const` item should never be interior mutable --> crates/flow-server/src/middleware/auth.rs:30:1 | 30 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key"); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default

warning: useless conversion to the same type: `serde_json::Value` --> crates/flow-server/src/db_worker/signer.rs:143:29 | 143 | Ok((signer.start(), signers_info.into())) | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `signers_info` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:337:17 | 337 | let res = self.save_signature(&id, &signature).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:324:17 | 324 | let res = self.set_node_finish(&id, &node_id, &times, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:319:17 | 319 | let res = self.push_node_error(&id, &node_id, &times, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:311:17 | 311 | / let res = self 312 | | .save_node_output(&id, &node_id, &times, &output) 313 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 311 ~ self 312 + .save_node_output(&id, &node_id, &times, &output) 313 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:304:17 | 304 | / let res = self 305 | | .new_node_run(&id, &node_id, &times, &time, &input) 306 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 304 ~ self 305 + .new_node_run(&id, &node_id, &times, &time, &input) 306 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:299:17 | 299 | let res = self.set_run_result(&id, &time, &not_run, &output).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:291:17 | 291 | / let res = self 292 | | .push_flow_log(&id, &index, &time, &level, &module, &content) 293 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 291 ~ self 292 + .push_flow_log(&id, &index, &time, &level, &module, &content) 293 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:285:17 | 285 | let res = self.push_flow_error(&id, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:280:17 | 280 | let res = self.set_start_time(&id, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:245:17 | 245 | let res = self.share_flow_run(id, user).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:337:17 | 337 | let res = self.save_signature(&id, &signature).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:324:17 | 324 | let res = self.set_node_finish(&id, &node_id, &times, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:319:17 | 319 | let res = self.push_node_error(&id, &node_id, &times, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:311:17 | 311 | / let res = self 312 | | .save_node_output(&id, &node_id, &times, &output) 313 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 311 ~ self 312 + .save_node_output(&id, &node_id, &times, &output) 313 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:304:17 | 304 | / let res = self 305 | | .new_node_run(&id, &node_id, &times, &time, &input) 306 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 304 ~ self 305 + .new_node_run(&id, &node_id, &times, &time, &input) 306 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:299:17 | 299 | let res = self.set_run_result(&id, &time, &not_run, &output).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:291:17 | 291 | / let res = self 292 | | .push_flow_log(&id, &index, &time, &level, &module, &content) 293 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 291 ~ self 292 + .push_flow_log(&id, &index, &time, &level, &module, &content) 293 + .await?; |

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:285:17 | 285 | let res = self.push_flow_error(&id, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/db/src/connection/admin.rs:41:56 | 41 | let info = format!("inserted at {}", Utc::now().to_string()); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:280:17 | 280 | let res = self.set_start_time(&id, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:245:17 | 245 | let res = self.share_flow_run(id, user).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: `to_string` applied to a type that implements `Display` in `format!` args --> crates/db/src/connection/admin.rs:41:56 | 41 | let info = format!("inserted at {}", Utc::now().to_string()); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default

warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:153:9 | 153 | / match self.fx2 { 154 | | Fx2::Underwater => { 155 | | let jellyfish = FxJellyfish::seed(); 156 | | self.fx_jellifish = jellyfish; ... | 168 | | _ => {} 169 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 153 ~ if self.fx2 == Fx2::Underwater { 154 + let jellyfish = FxJellyfish::seed(); 155 + self.fx_jellifish = jellyfish; 156 + 157 + self.underwater_fog_amount = rand::random::<f64>() * 30.0; 158 + self.background_underwater_color_hue = 38.8; 159 + 160 + let env_light = if self.fx0 == Fx0::Hologram { 161 + EnvLight::UnderwaterHologram 162 + } else { 163 + EnvLight::Underwater 164 + }; 165 + self.env_light = env_light; 166 + } |

warning: using `clone` on type `Request` which implements the `Copy` trait --> lib/flow-lib/src/context.rs:116:18 | 116 | Some(req.clone()) | ^^^^^^^^^^^ help: try dereferencing it: `*req` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: using `clone` on type `Request` which implements the `Copy` trait --> lib/flow-lib/src/context.rs:116:18 | 116 | Some(req.clone()) | ^^^^^^^^^^^ help: try dereferencing it: `*req` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:153:9 | 153 | / match self.fx2 { 154 | | Fx2::Underwater => { 155 | | let jellyfish = FxJellyfish::seed(); 156 | | self.fx_jellifish = jellyfish; ... | 168 | | _ => {} 169 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 153 ~ if self.fx2 == Fx2::Underwater { 154 + let jellyfish = FxJellyfish::seed(); 155 + self.fx_jellifish = jellyfish; 156 + 157 + self.underwater_fog_amount = rand::random::<f64>() * 30.0; 158 + self.background_underwater_color_hue = 38.8; 159 + 160 + let env_light = if self.fx0 == Fx0::Hologram { 161 + EnvLight::UnderwaterHologram 162 + } else { 163 + EnvLight::Underwater 164 + }; 165 + self.env_light = env_light; 166 + } |

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/