Skip to content

misc (#53)

misc (#53) #141

Triggered via push February 9, 2024 09:09
Status Success
Total duration 13m 17s
Artifacts

basic.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

69 warnings
you seem to use `.enumerate()` and immediately discard the index: crates/cmds-solana/src/wormhole/verify_signatures.rs#L74
warning: you seem to use `.enumerate()` and immediately discard the index --> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31 | 74 | for (_tx_index, chunk) in signature_items.chunks(7).enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 74 | for chunk in signature_items.chunks(7) { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
a `const` item should never be interior mutable: crates/flow-server/src/middleware/auth.rs#L73
warning: a `const` item should never be interior mutable --> crates/flow-server/src/middleware/auth.rs:73:1 | 73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key"); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default
a `const` item should never be interior mutable: crates/flow-server/src/middleware/auth.rs#L73
warning: a `const` item should never be interior mutable --> crates/flow-server/src/middleware/auth.rs:73:1 | 73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key"); | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | make this a static item (maybe with lazy_static) | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/update.rs#L136
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/update.rs:136:28 | 136 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 137 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/transfer.rs#L190
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/transfer.rs:190:28 | 190 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 191 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/burn.rs#L133
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/burn.rs:133:28 | 133 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 134 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
you seem to use `.enumerate()` and immediately discard the index: crates/cmds-solana/src/wormhole/verify_signatures.rs#L74
warning: you seem to use `.enumerate()` and immediately discard the index --> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31 | 74 | for (_tx_index, chunk) in signature_items.chunks(7).enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 74 | for chunk in signature_items.chunks(7) { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/update.rs#L136
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/update.rs:136:28 | 136 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 137 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/transfer.rs#L190
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/transfer.rs:190:28 | 190 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 191 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: crates/cmds-solana/src/compression/burn.rs#L133
warning: useless conversion to the same type: `u32` --> crates/cmds-solana/src/compression/burn.rs:133:28 | 133 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32) | ____________________________^ 134 | | .try_into() | |___________________________^ | = help: consider removing `.try_into()` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
redundant closure: crates/db/src/connection/conn_impl.rs#L815
warning: redundant closure --> crates/db/src/connection/conn_impl.rs:815:62 | 815 | let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>()); | ^^^^^^^^^^^ help: replace the closure with the function itself: `Json` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L362
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:362:17 | 362 | let res = self.save_signature(&id, &signature).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L337
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:337:17 | 337 | let res = self.set_node_finish(&id, &node_id, &times, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L332
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:332:17 | 332 | let res = self.push_node_error(&id, &node_id, &times, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L324
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:324:17 | 324 | / let res = self 325 | | .save_node_output(&id, &node_id, &times, &output) 326 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 324 ~ self 325 + .save_node_output(&id, &node_id, &times, &output) 326 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L317
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:317:17 | 317 | / let res = self 318 | | .new_node_run(&id, &node_id, &times, &time, &input) 319 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 317 ~ self 318 + .new_node_run(&id, &node_id, &times, &time, &input) 319 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L312
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:312:17 | 312 | let res = self.set_run_result(&id, &time, &not_run, &output).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L304
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:304:17 | 304 | / let res = self 305 | | .push_flow_log(&id, &index, &time, &level, &module, &content) 306 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 304 ~ self 305 + .push_flow_log(&id, &index, &time, &level, &module, &content) 306 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L298
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:298:17 | 298 | let res = self.push_flow_error(&id, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L293
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:293:17 | 293 | let res = self.set_start_time(&id, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L258
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:258:17 | 258 | let res = self.share_flow_run(id, user).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default
redundant closure: crates/db/src/connection/conn_impl.rs#L815
warning: redundant closure --> crates/db/src/connection/conn_impl.rs:815:62 | 815 | let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>()); | ^^^^^^^^^^^ help: replace the closure with the function itself: `Json` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L362
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:362:17 | 362 | let res = self.save_signature(&id, &signature).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L337
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:337:17 | 337 | let res = self.set_node_finish(&id, &node_id, &times, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L332
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:332:17 | 332 | let res = self.push_node_error(&id, &node_id, &times, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L324
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:324:17 | 324 | / let res = self 325 | | .save_node_output(&id, &node_id, &times, &output) 326 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 324 ~ self 325 + .save_node_output(&id, &node_id, &times, &output) 326 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L317
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:317:17 | 317 | / let res = self 318 | | .new_node_run(&id, &node_id, &times, &time, &input) 319 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 317 ~ self 318 + .new_node_run(&id, &node_id, &times, &time, &input) 319 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L312
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:312:17 | 312 | let res = self.set_run_result(&id, &time, &not_run, &output).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L304
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:304:17 | 304 | / let res = self 305 | | .push_flow_log(&id, &index, &time, &level, &module, &content) 306 | | .await?; | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value help: omit the `let` binding | 304 ~ self 305 + .push_flow_log(&id, &index, &time, &level, &module, &content) 306 + .await?; |
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L298
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:298:17 | 298 | let res = self.push_flow_error(&id, &error).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L293
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:293:17 | 293 | let res = self.set_start_time(&id, &time).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
this let-binding has unit value: crates/db/src/connection/proxied_user_conn.rs#L258
warning: this let-binding has unit value --> crates/db/src/connection/proxied_user_conn.rs:258:17 | 258 | let res = self.share_flow_run(id, user).await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: crates/cmds-std/src/wait_cmd.rs#L30
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> crates/cmds-std/src/wait_cmd.rs:30:5 | 30 | / match input.duration_ms { 31 | | Some(duration) => { 32 | | time::sleep(Duration::from_millis(duration)).await; 33 | | } 34 | | None => {} 35 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 30 ~ if let Some(duration) = input.duration_ms { 31 + time::sleep(Duration::from_millis(duration)).await; 32 ~ }; |
module has the same name as its containing module: crates/cmds-std/src/supabase/mod.rs#L1
warning: module has the same name as its containing module --> crates/cmds-std/src/supabase/mod.rs:1:1 | 1 | pub mod supabase; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
unknown lint: `clippy`: crates/db/src/connection/proxied_user_conn.rs#L1
warning: unknown lint: `clippy` --> crates/db/src/connection/proxied_user_conn.rs:1:10 | 1 | #![allow(clippy)] | ^^^^^^ | = note: `#[warn(unknown_lints)]` on by default
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: crates/cmds-std/src/wait_cmd.rs#L30
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> crates/cmds-std/src/wait_cmd.rs:30:5 | 30 | / match input.duration_ms { 31 | | Some(duration) => { 32 | | time::sleep(Duration::from_millis(duration)).await; 33 | | } 34 | | None => {} 35 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 30 ~ if let Some(duration) = input.duration_ms { 31 + time::sleep(Duration::from_millis(duration)).await; 32 ~ }; |
unknown lint: `clippy`: crates/db/src/connection/proxied_user_conn.rs#L1
warning: unknown lint: `clippy` --> crates/db/src/connection/proxied_user_conn.rs:1:10 | 1 | #![allow(clippy)] | ^^^^^^ | = note: `#[warn(unknown_lints)]` on by default
module has the same name as its containing module: crates/cmds-std/src/supabase/mod.rs#L1
warning: module has the same name as its containing module --> crates/cmds-std/src/supabase/mod.rs:1:1 | 1 | pub mod supabase; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
use of deprecated method `indexmap::map::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.: crates/cmds-std/src/json_extract.rs#L55
warning: use of deprecated method `indexmap::map::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior. --> crates/cmds-std/src/json_extract.rs:55:31 | 55 | let trimmed = outputs.remove("trimmed_json").unwrap(); | ^^^^^^
use of deprecated method `indexmap::map::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.: crates/cmds-std/src/json_extract.rs#L54
warning: use of deprecated method `indexmap::map::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior. --> crates/cmds-std/src/json_extract.rs:54:29 | 54 | let value = outputs.remove("value").unwrap(); | ^^^^^^ | = note: `#[warn(deprecated)]` on by default
use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.: lib/flow-value/src/lib.rs#L884
warning: use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior. --> lib/flow-value/src/lib.rs:884:15 | 884 | v.remove("value").unwrap(), | ^^^^^^ | = note: `#[warn(deprecated)]` on by default
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L447
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:447:9 | 447 | / match self.fx0 { 448 | | Fx0::Wood => { 449 | | self.wood_variation = WoodVariation::choose(rng); 450 | | } 451 | | _ => {} 452 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 447 ~ if self.fx0 == Fx0::Wood { 448 + self.wood_variation = WoodVariation::choose(rng); 449 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L437
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:437:9 | 437 | / match self.fx0 { 438 | | Fx0::Marble => { 439 | | self.marble_variation = MarbleVariation::choose(rng); 440 | | } 441 | | _ => {} 442 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 437 ~ if self.fx0 == Fx0::Marble { 438 + self.marble_variation = MarbleVariation::choose(rng); 439 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L427
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:427:9 | 427 | / match self.fx0 { 428 | | Fx0::No => { 429 | | self.body_material_variation = BodyMaterialVariations::choose(rng); 430 | | } 431 | | _ => {} 432 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 427 ~ if self.fx0 == Fx0::No { 428 + self.body_material_variation = BodyMaterialVariations::choose(rng); 429 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L380
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:380:9 | 380 | / match self.fx2 { 381 | | Fx2::Underwater => { 382 | | let jellyfish = FxJellyfish::choose(rng); 383 | | self.fx_jellifish = jellyfish; ... | 395 | | _ => {} 396 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 380 ~ if self.fx2 == Fx2::Underwater { 381 + let jellyfish = FxJellyfish::choose(rng); 382 + self.fx_jellifish = jellyfish; 383 + 384 + self.underwater_fog_amount = rng.gen::<f64>() * 30.0; 385 + self.background_underwater_color_hue = 38.8; 386 + 387 + let env_light = if self.fx0 == Fx0::Hologram { 388 + EnvLight::UnderwaterHologram 389 + } else { 390 + EnvLight::Underwater 391 + }; 392 + self.env_light = env_light; 393 + } |
this returns a `Result<_, ()>`: crates/utils/src/address_book.rs#L64
warning: this returns a `Result<_, ()>` --> crates/utils/src/address_book.rs:64:5 | 64 | / pub fn try_start_with_context<A, F>( 65 | | &mut self, 66 | | id: A::ID, 67 | | make_actor: F, 68 | | rt: ArbiterHandle, 69 | | ) -> Result<actix::Addr<A>, ()> | |___________________________________^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L447
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:447:9 | 447 | / match self.fx0 { 448 | | Fx0::Wood => { 449 | | self.wood_variation = WoodVariation::choose(rng); 450 | | } 451 | | _ => {} 452 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 447 ~ if self.fx0 == Fx0::Wood { 448 + self.wood_variation = WoodVariation::choose(rng); 449 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L437
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:437:9 | 437 | / match self.fx0 { 438 | | Fx0::Marble => { 439 | | self.marble_variation = MarbleVariation::choose(rng); 440 | | } 441 | | _ => {} 442 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 437 ~ if self.fx0 == Fx0::Marble { 438 + self.marble_variation = MarbleVariation::choose(rng); 439 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L427
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:427:9 | 427 | / match self.fx0 { 428 | | Fx0::No => { 429 | | self.body_material_variation = BodyMaterialVariations::choose(rng); 430 | | } 431 | | _ => {} 432 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 427 ~ if self.fx0 == Fx0::No { 428 + self.body_material_variation = BodyMaterialVariations::choose(rng); 429 + } |
you seem to be trying to use `match` for an equality check. Consider using `if`: crates/pdg-common/src/nft_metadata/generate.rs#L380
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/pdg-common/src/nft_metadata/generate.rs:380:9 | 380 | / match self.fx2 { 381 | | Fx2::Underwater => { 382 | | let jellyfish = FxJellyfish::choose(rng); 383 | | self.fx_jellifish = jellyfish; ... | 395 | | _ => {} 396 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 380 ~ if self.fx2 == Fx2::Underwater { 381 + let jellyfish = FxJellyfish::choose(rng); 382 + self.fx_jellifish = jellyfish; 383 + 384 + self.underwater_fog_amount = rng.gen::<f64>() * 30.0; 385 + self.background_underwater_color_hue = 38.8; 386 + 387 + let env_light = if self.fx0 == Fx0::Hologram { 388 + EnvLight::UnderwaterHologram 389 + } else { 390 + EnvLight::Underwater 391 + }; 392 + self.env_light = env_light; 393 + } |
this returns a `Result<_, ()>`: crates/utils/src/address_book.rs#L64
warning: this returns a `Result<_, ()>` --> crates/utils/src/address_book.rs:64:5 | 64 | / pub fn try_start_with_context<A, F>( 65 | | &mut self, 66 | | id: A::ID, 67 | | make_actor: F, 68 | | rt: ArbiterHandle, 69 | | ) -> Result<actix::Addr<A>, ()> | |___________________________________^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
Clippy lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions/checkout@v3, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions/checkout@v3, Swatinem/rust-cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Unit test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Unit test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/