Fix missing command #143
clippy
49 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 49 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check warning on line 74 in crates/cmds-solana/src/wormhole/verify_signatures.rs
github-actions / clippy
you seem to use `.enumerate()` and immediately discard the index
warning: you seem to use `.enumerate()` and immediately discard the index
--> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31
|
74 | for (_tx_index, chunk) in signature_items.chunks(7).enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
74 | for chunk in signature_items.chunks(7) {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 73 in crates/flow-server/src/middleware/auth.rs
github-actions / clippy
a `const` item should never be interior mutable
warning: a `const` item should never be interior mutable
--> crates/flow-server/src/middleware/auth.rs:73:1
|
73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key");
| -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| make this a static item (maybe with lazy_static)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
= note: `#[warn(clippy::declare_interior_mutable_const)]` on by default
Check warning on line 73 in crates/flow-server/src/middleware/auth.rs
github-actions / clippy
a `const` item should never be interior mutable
warning: a `const` item should never be interior mutable
--> crates/flow-server/src/middleware/auth.rs:73:1
|
73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key");
| -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| make this a static item (maybe with lazy_static)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
= note: `#[warn(clippy::declare_interior_mutable_const)]` on by default
Check warning on line 137 in crates/cmds-solana/src/compression/update.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/update.rs:136:28
|
136 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
137 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 191 in crates/cmds-solana/src/compression/transfer.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/transfer.rs:190:28
|
190 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
191 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 134 in crates/cmds-solana/src/compression/burn.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/burn.rs:133:28
|
133 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
134 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 74 in crates/cmds-solana/src/wormhole/verify_signatures.rs
github-actions / clippy
you seem to use `.enumerate()` and immediately discard the index
warning: you seem to use `.enumerate()` and immediately discard the index
--> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31
|
74 | for (_tx_index, chunk) in signature_items.chunks(7).enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
74 | for chunk in signature_items.chunks(7) {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 137 in crates/cmds-solana/src/compression/update.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/update.rs:136:28
|
136 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
137 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 191 in crates/cmds-solana/src/compression/transfer.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/transfer.rs:190:28
|
190 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
191 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 134 in crates/cmds-solana/src/compression/burn.rs
github-actions / clippy
useless conversion to the same type: `u32`
warning: useless conversion to the same type: `u32`
--> crates/cmds-solana/src/compression/burn.rs:133:28
|
133 | Some(asset) => (asset.result.node_index as u32 - 2 * asset.result.proof.len() as u32)
| ____________________________^
134 | | .try_into()
| |___________________________^
|
= help: consider removing `.try_into()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 35 in crates/cmds-std/src/wait_cmd.rs
github-actions / clippy
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> crates/cmds-std/src/wait_cmd.rs:30:5
|
30 | / match input.duration_ms {
31 | | Some(duration) => {
32 | | time::sleep(Duration::from_millis(duration)).await;
33 | | }
34 | | None => {}
35 | | };
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
30 ~ if let Some(duration) = input.duration_ms {
31 + time::sleep(Duration::from_millis(duration)).await;
32 ~ };
|
Check warning on line 1 in crates/cmds-std/src/supabase/mod.rs
github-actions / clippy
module has the same name as its containing module
warning: module has the same name as its containing module
--> crates/cmds-std/src/supabase/mod.rs:1:1
|
1 | pub mod supabase;
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
Check warning on line 815 in crates/db/src/connection/conn_impl.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> crates/db/src/connection/conn_impl.rs:815:62
|
815 | let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>());
| ^^^^^^^^^^^ help: replace the closure with the function itself: `Json`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 360 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:360:17
|
360 | let res = self.save_signature(&id, &signature).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 335 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:335:17
|
335 | let res = self.set_node_finish(&id, &node_id, ×, &time).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, ×, &time).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 330 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:330:17
|
330 | let res = self.push_node_error(&id, &node_id, ×, &error).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, ×, &error).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 324 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:322:17
|
322 | / let res = self
323 | | .save_node_output(&id, &node_id, ×, &output)
324 | | .await?;
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
|
322 ~ self
323 + .save_node_output(&id, &node_id, ×, &output)
324 + .await?;
|
Check warning on line 317 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:315:17
|
315 | / let res = self
316 | | .new_node_run(&id, &node_id, ×, &time, &input)
317 | | .await?;
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
|
315 ~ self
316 + .new_node_run(&id, &node_id, ×, &time, &input)
317 + .await?;
|
Check warning on line 310 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:310:17
|
310 | let res = self.set_run_result(&id, &time, ¬_run, &output).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, ¬_run, &output).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 304 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:302:17
|
302 | / let res = self
303 | | .push_flow_log(&id, &index, &time, &level, &module, &content)
304 | | .await?;
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
|
302 ~ self
303 + .push_flow_log(&id, &index, &time, &level, &module, &content)
304 + .await?;
|
Check warning on line 296 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:296:17
|
296 | let res = self.push_flow_error(&id, &error).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 291 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:291:17
|
291 | let res = self.set_start_time(&id, &time).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Check warning on line 815 in crates/db/src/connection/conn_impl.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> crates/db/src/connection/conn_impl.rs:815:62
|
815 | let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>());
| ^^^^^^^^^^^ help: replace the closure with the function itself: `Json`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 256 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:256:17
|
256 | let res = self.share_flow_run(id, user).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
Check warning on line 360 in crates/db/src/connection/proxied_user_conn.rs
github-actions / clippy
this let-binding has unit value
warning: this let-binding has unit value
--> crates/db/src/connection/proxied_user_conn.rs:360:17
|
360 | let res = self.save_signature(&id, &signature).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value