Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: FN <[email protected]>
  • Loading branch information
AwareFoxy and FireNameFN authored Dec 6, 2024
1 parent d9d2e34 commit 0223e54
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected override void Started(EntityUid uid, SpaceLawChangeRuleComponent compo
base.Started(uid, component, gameRule, args);

if (!_cfg.GetCVar(NextVars.LRPEnabled))
return;
return;

// Loading a prototype dataset
if (!_prototypeManager.TryIndex<LocalizedDatasetPrototype>(component.LawLocalizedDataset, out var dataset))
Expand All @@ -57,7 +57,7 @@ protected override void Started(EntityUid uid, SpaceLawChangeRuleComponent compo
var activeLaws = GetActiveSpaceLaws();

// Excluding active laws from selection
var availableLaws = _sequenceLaws.Except(activeLaws).ToList();
var availableLaws = _sequenceLaws.Except(activeLaws).ToArray();
if (availableLaws.Count == 0)

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

Operator '==' cannot be applied to operands of type 'method group' and 'int'

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

Operator '==' cannot be applied to operands of type 'method group' and 'int'

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

Operator '==' cannot be applied to operands of type 'method group' and 'int'

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

Operator '==' cannot be applied to operands of type 'method group' and 'int'

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Operator '==' cannot be applied to operands of type 'method group' and 'int'

Check failure on line 61 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Operator '==' cannot be applied to operands of type 'method group' and 'int'
{
availableLaws = _sequenceLaws;

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / Test Packaging

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / YAML Linter

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'

Check failure on line 63 in Content.Server/_CorvaxNext/StationEvents/Events/SpaceLawChange.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

Cannot implicitly convert type 'System.Collections.Generic.List<string>' to 'string[]'
Expand Down

0 comments on commit 0223e54

Please sign in to comment.