-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Система пробивания препятствий пулями #26
base: master
Are you sure you want to change the base?
Conversation
@@ -18,9 +19,14 @@ public sealed class ProjectileSystem : SharedProjectileSystem | |||
[Dependency] private readonly GunSystem _guns = default!; | |||
[Dependency] private readonly SharedCameraRecoilSystem _sharedCameraRecoil = default!; | |||
|
|||
private EntityQuery<PenetratableComponent> _penetratableQuery; | |||
|
|||
private Random _random = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему не IRobustRandom, который предоставляется нам через зависимости в IoC
@@ -60,6 +60,8 @@ | |||
components: | |||
- type: Damageable | |||
damageContainer: Biological | |||
- type: Penetratable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Подобные изменение должны иметь комментарий, если вы меняете прототипы официального контента
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Этот компонент и так новый. Мы договорились не помечать в прототипах новые компоненты, так как и так понятно, что он не оффами добавлен.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Гадэм, в любом случае это будет на совести тех, кто делает апстртмы, чем я не занимаюсь
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Этот компонент и так новый. Мы договорились не помечать в прототипах новые компоненты, так как и так понятно, что он не оффами добавлен.
чзх, добавляй
@@ -67,9 +73,19 @@ private void OnStartCollide(EntityUid uid, ProjectileComponent component, ref St | |||
_sharedCameraRecoil.KickCamera(target, direction); | |||
} | |||
|
|||
component.DamagedEntity = true; | |||
// Corvax-Next-Penetration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надо открыть и закрыть подобный комментарий, для удобства
Ссылка на ветку
https://discord.com/channels/919301044784226385/1303634507383181377
Технические детали
Изменён Server/PenetrationSystem
Добавлен компонент Penetratable
Добавлен PenetrationPower в Projectile
Список изменений
🆑