Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add ICloneable support to ComponentNetworkGenerator" #5687

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ElectroJr
Copy link
Member

Reverts #5656

Generates invalid code when using something like

[DataField, AutoNetworkedField]
public TestClass TestField = new();

[Serializable, NetSerializable]
public sealed class TestClass : ICloneable
{
    public object Clone() => new();
}

See https://discord.com/channels/310555209753690112/900426319433728030/1341968643646423210

@ElectroJr ElectroJr merged commit f29949a into master Feb 20, 2025
3 checks passed
@deltanedas
Copy link
Contributor

was good for rooting out uses of String at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants