Make channel ID optional when replying #1145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you regen the schema for this pr and then I'll merge |
DEVTomatoCake
force-pushed
the
fix/reply-channelid-optional
branch
from
42cf4b0 to
df9153f
Compare
|
Why close it? You just needed to merge and regen the schema haha |
Because it didn't let me merge due to a non-existing conflict in the schemas file? |
|
You wouldn't be able to do it in the web UI. if you started a merge in cli and then regened the schema before committing it would've been fine |
|
That's what I did, I've tried it in CLI but nope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
guild_idandchannel_idoptional when sending a message for compatibility, e.g. discord.js fails to use replies otherwise.TS complains about some properties being missing so it was suggested to simply add
@ts-expect-errorand be done with it 🤷