Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proper "animated" property for emojis #1146

Merged

Conversation

DEVTomatoCake
Copy link
Member

Instead of defaulting to animated: false this PR sets it to true if the MIME type of the uploaded file is set to image/gif.

This uses the same detection as the uploading process in line 126:

const mimetype = body.split(":")[1].split(";")[0];

@TheArcaneBrony
Copy link
Member

what about webm/apng?

@DEVTomatoCake
Copy link
Member Author

what about webm/apng?

Added

@MaddyUnderStars MaddyUnderStars merged commit 2f679fd into spacebarchat:master Jul 17, 2024
3 checks passed
@DEVTomatoCake DEVTomatoCake deleted the feat/detect-animated-emoji branch July 17, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants