Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send 204 status #1175

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Send 204 status #1175

merged 1 commit into from
Aug 15, 2024

Conversation

DEVTomatoCake
Copy link
Member

  • Sends the 204 status instead of only setting it, causing the request to time out
  • Proper error for the after/before parameters
  • Remove .status(204) when sending a body

HTTP 204 No Content

@DEVTomatoCake
Copy link
Member Author

(Style check fail isn't my fault, it's complaining about hashes.json)

@MaddyUnderStars MaddyUnderStars merged commit 771d6a2 into spacebarchat:master Aug 15, 2024
2 of 3 checks passed
@DEVTomatoCake DEVTomatoCake deleted the fix/send-204-status branch August 15, 2024 13:35
@DEVTomatoCake DEVTomatoCake mentioned this pull request Aug 21, 2024
Closed
@kozabrada123 kozabrada123 mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DEVTomatoCake @MaddyUnderStars