New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in image proxy fixes #1199

Merged

MaddyUnderStars merged 2 commits into spacebarchat:master from DEVTomatoCake:fix/built-in-image-proxy

Aug 28, 2024

Member

DEVTomatoCake commented Aug 25, 2024

I've missed a few things in #1126:

Proxy shouldn't require auth because it's not really possible to handle that in clients across domains
Imagor leaves out the protocol in the proxy URL, therefore the proxy has to re-add it. Given that SSL is quite common nowadays using https:// should be fine.

DEVTomatoCake added 2 commits

August 25, 2024 06:50


          Remove auth requirement & fix image path

1bf2424


          Run prettier

b73b4e9

MaddyUnderStars merged commit 31ac4a0 into spacebarchat:master

3 checks passed

DEVTomatoCake deleted the fix/built-in-image-proxy branch

August 28, 2024 02:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet