Allow to use = in the actual variable definition

internal/cmd/stack/local_preview.go

@@ -148,35 +148,35 @@ type EnvironmentVariable struct {
 	Value graphql.String `json:"value"`
 }
 
-func parseEnvVariablesForLocalPreview(cliCtx *cli.Context) ([]EnvironmentVariable, error) {
-	envVars := make([]EnvironmentVariable, 0)
+func parseEnvVar(env string, envVars []EnvironmentVariable, mutateKey func(string) string) error {
+	parts := strings.SplitN(env, "=", 2)
+	if len(parts) != 2 {
+		return fmt.Errorf("invalid environment variable %q, must be in the form of KEY=VALUE", env)
+	}
 
-	parseFn := func(ev string, mutateKey func(string) string) error {
-		parts := strings.Split(ev, "=")
-		if len(parts) != 2 {
-			return fmt.Errorf("invalid environment variable %q, must be in the form of KEY=VALUE", ev)
-		}
+	if mutateKey != nil {
+		parts[0] = mutateKey(parts[0])
+	}
 
-		if mutateKey != nil {
-			parts[0] = mutateKey(parts[0])
-		}
+	envVars = append(envVars, EnvironmentVariable{
+		Key:   graphql.String(parts[0]),
+		Value: graphql.String(parts[1]),
+	})
 
-		envVars = append(envVars, EnvironmentVariable{
-			Key:   graphql.String(parts[0]),
-			Value: graphql.String(parts[1]),
-		})
+	return nil
+}
 
-		return nil
-	}
+func parseEnvVariablesForLocalPreview(cliCtx *cli.Context) ([]EnvironmentVariable, error) {
+	envVars := make([]EnvironmentVariable, 0)
 
 	for _, ev := range cliCtx.StringSlice(flagOverrideEnvVars.Name) {
-		if err := parseFn(ev, nil); err != nil {
+		if err := parseEnvVar(ev, envVars, nil); err != nil {
 			return nil, err
 		}
 	}
 
 	for _, ev := range cliCtx.StringSlice(flagOverrideEnvVarsTF.Name) {
-		if err := parseFn(ev, func(s string) string {
+		if err := parseEnvVar(ev, envVars, func(s string) string {
 			return strings.Join([]string{"TF_", s}, "")
 		}); err != nil {
 			return nil, err