-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user facing error massage when the stack is not found #182
Improve user facing error massage when the stack is not found #182
Conversation
We have this function called Because this is called every time we parse the provided if cliCtx.IsSet(flagStackID.Name) {
return cliCtx.String(flagStackID.Name), nil
} Would you mind look in to that and seeing if that actually works? |
Signed-off-by: Michal Wasilewski <[email protected]>
08fcc06
to
86a86c3
Compare
Signed-off-by: Michal Wasilewski <[email protected]>
You're right, it makes more sense to check for stack presence when we're extracting the stack id. The additional benefit of this is that this function is used in other places so we get nice error handling in those places as well. @tomasmik let me know what you think of this approach |
Co-authored-by: Tomas <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
closes: https://app.clickup.com/t/862k09kgc
Includes in the error message a hint about how to list available stacks.
Note: The GraphQL API doesn't return errors that can be typed. The string parsing is a dirty hack, if anyone knows of a better way to approach it let me know.