feat: Allow to provide run ID instead of stack ID in some command #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0michalsokolowski0
changed the title
0michalsokolowski0
requested review from
tomasmik,
mbialon,
Yantrio and
silviutanasa
mbialon
requested changes
Sep 9, 2024
tomasmik
approved these changes
Sep 9, 2024
internal/cmd/stack/stack_selector.go
Outdated
| return stack, nil | ||
| } else if cliCtx.IsSet(flagRun.Name) { | ||
| runID := cliCtx.String(flagRun.Name) | ||
| stack, found, err := stackGetByRunID(cliCtx.Context, runID) |
There was a problem hiding this comment.
why the double logic (using bool here and not using it the other function)? just return the same error as we do in the previous method maybe?
0michalsokolowski0
deleted the
allow-to-provide-runID-instead-of-stackID-in-some-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230