Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add run controller tests #6

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat: add run controller tests #6

merged 1 commit into from
Mar 1, 2024

Conversation

eliecharra
Copy link
Member

No description provided.

@eliecharra eliecharra requested a review from michalg9 February 29, 2024 15:31
eliecharra
eliecharra commented Feb 29, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@eliecharra eliecharra force-pushed the feat/add_run_controller_tests branch from 3558d3f to 23971a4 Compare February 29, 2024 15:37
adamconnelly
adamconnelly approved these changes Feb 29, 2024
View reviewed changes
Copy link

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it seems a much more maintainable approach than the Gingko tests.

@michalg9 michalg9 mentioned this pull request Mar 1, 2024
Merged
@eliecharra eliecharra changed the base branch from feat/add_run_controller to main March 1, 2024 10:56
@eliecharra eliecharra marked this pull request as ready for review March 1, 2024 10:58
@eliecharra eliecharra force-pushed the feat/add_run_controller_tests branch from 23971a4 to dd07c0b Compare March 1, 2024 10:58
@eliecharra eliecharra requested a review from a team as a code owner March 1, 2024 10:58
@eliecharra eliecharra merged commit 3fb2d86 into main Mar 1, 2024
5 checks passed
@peterdeme peterdeme deleted the feat/add_run_controller_tests branch May 31, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMacies TheMacies TheMacies approved these changes

@adamconnelly adamconnelly adamconnelly approved these changes

@michalg9 michalg9 Awaiting requested review from michalg9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliecharra @adamconnelly @TheMacies