Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replication regions to Azure job #64

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add replication regions to Azure job #64

merged 3 commits into from
Sep 23, 2024

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Sep 20, 2024

Description of the change

Currently, our customers use these regions for their workers. We can add more later.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

content {
name = target_region.value
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A target region to store the image version in. The attribute supersedes replication_regions which is now considered deprecated. One or more target_region blocks can be specified for storing an imager version to various regions. In addition to specifying a region, a DiskEncryptionSetId can be specified for each target region to support multi-region disk encryption. At a minimum their must be one target region entry for the primary build region where the image version will be stored. Target region must only contain one entry matching the build region when using shallow replication.

@peterdeme peterdeme marked this pull request as ready for review September 21, 2024 12:30
@peterdeme peterdeme requested a review from a team as a code owner September 21, 2024 12:30
gcp.pkr.hcl Show resolved Hide resolved
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just noticed something related to the target region blocks.

.github/workflows/build_gcp_azure_manual.yml Show resolved Hide resolved
adamconnelly
adamconnelly previously approved these changes Sep 23, 2024
@peterdeme peterdeme merged commit 76f4aa9 into main Sep 23, 2024
3 checks passed
@peterdeme peterdeme deleted the setup-azure-regions branch September 23, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants