Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for users #474

Merged
merged 13 commits into from
Oct 23, 2023
Merged

Add support for users #474

merged 13 commits into from
Oct 23, 2023

Conversation

mwasilew2
Copy link
Contributor

@mwasilew2 mwasilew2 commented Oct 10, 2023

Description of the change

This is part of "User Management" set of features. It adds to the terraform provider support for managing user mappings. See the relevant clickup issue for more details.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

Signed-off-by: Michal Wasilewski <[email protected]>
@mwasilew2 mwasilew2 marked this pull request as draft October 10, 2023 09:33
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
@mwasilew2
Copy link
Contributor Author

This is blocked on API changes necessary on the backend side

Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
@mwasilew2
Copy link
Contributor Author

mwasilew2 commented Oct 13, 2023

blocked by: https://github.com/spacelift-io/backend/pull/5658

Note: the tests will be failing until the backend PR is deployed

@mwasilew2 mwasilew2 marked this pull request as ready for review October 13, 2023 14:06
Signed-off-by: Michal Wasilewski <[email protected]>
Signed-off-by: Michal Wasilewski <[email protected]>
@mwasilew2 mwasilew2 marked this pull request as draft October 17, 2023 14:21
@mwasilew2 mwasilew2 marked this pull request as ready for review October 17, 2023 14:33
@mwasilew2
Copy link
Contributor Author

The backend PR was merged, the tests are passsing, this is ready for review

Copy link
Contributor

@michieldewilde michieldewilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the naming is an issue.

spacelift/provider.go Outdated Show resolved Hide resolved
spacelift/resource_user_mapping_test.go Outdated Show resolved Hide resolved
@mwasilew2
Copy link
Contributor Author

ping @michieldewilde

@mwasilew2 mwasilew2 merged commit 23aa28a into main Oct 23, 2023
@mwasilew2 mwasilew2 deleted the mwasilew2/add-support-for-users branch October 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants