Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHubEnterprise multi VCS #477

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add GitHubEnterprise multi VCS #477

merged 1 commit into from
Nov 17, 2023

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Oct 29, 2023 •
edited
Loading

Description of the change

Add ghe multi vcs, specifically for GitHub Enterprise.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@spacelift-io spacelift-io deleted a comment from Clickup-user Oct 29, 2023
peterdeme
peterdeme commented Oct 29, 2023
View reviewed changes
spacelift/data_github_enterprise_integration.go
@@ -63,10 +114,22 @@ func dataGithubEnterpriseIntegrationRead(ctx context.Context, d *schema.Resource
return diag.Errorf("github enterprise integration not found")
}

d.SetId("spacelift_github_enterprise_integration_id") // TF expects id to be set otherwise it will fail
Copy link
Contributor Author

@peterdeme peterdeme Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the indentifier could be a breaking change but since this is just a data source I don't think this actually matters or breaks anything

@peterdeme peterdeme force-pushed the cu-85yxtb5ku-add-ghe-multi-vcs branch 4 times, most recently from 3b6d754 to 7a89db0 Compare October 29, 2023 10:31
github-actions[bot]
github-actions bot reviewed Oct 29, 2023
View reviewed changes
spacelift/data_stack.go Outdated Show resolved Hide resolved
@peterdeme peterdeme force-pushed the cu-85yxtb5ku-add-ghe-multi-vcs branch 5 times, most recently from 6f84d5c to 9aade6b Compare October 29, 2023 12:52
@peterdeme peterdeme marked this pull request as ready for review October 30, 2023 12:50
@marcinwyszynski marcinwyszynski marked this pull request as draft November 17, 2023 09:45
@peterdeme peterdeme force-pushed the cu-85yxtb5ku-add-ghe-multi-vcs branch from 9aade6b to 7a106fd Compare November 17, 2023 15:27
@peterdeme peterdeme force-pushed the cu-85yxtb5ku-add-ghe-multi-vcs branch from 7a106fd to 5eeba13 Compare November 17, 2023 15:46
@peterdeme peterdeme changed the base branch from main to multivcs-trunk November 17, 2023 16:24
@peterdeme peterdeme marked this pull request as ready for review November 17, 2023 16:24
@peterdeme peterdeme merged commit d28b12b into multivcs-trunk Nov 17, 2023
7 checks passed
@peterdeme peterdeme deleted the cu-85yxtb5ku-add-ghe-multi-vcs branch November 17, 2023 16:25
peterdeme added a commit that referenced this pull request Nov 28, 2023
@peterdeme
GHE/Azure/Gitlab multi VCS (#477)
059e66c
peterdeme added a commit that referenced this pull request Nov 28, 2023
@peterdeme
GHE/Azure/Gitlab multi VCS (#477)
b9d7d62
peterdeme added a commit that referenced this pull request Jan 10, 2024
@peterdeme
GHE/Azure/Gitlab multi VCS (#477)
56187da
peterdeme added a commit that referenced this pull request Jan 22, 2024
@peterdeme
Multi VCS (#477)
c02aae7
peterdeme added a commit that referenced this pull request Jan 22, 2024
@peterdeme
Multi VCS (#477)
00daf9a
truszkowski added a commit that referenced this pull request Feb 2, 2024
@truszkowski
Merge pull request #505 from spacelift-io/multivcs-add-missing-webhoo…
46c4efe 
…k-url-for-github

Multi VCS - add missing webhook_url for GitHub (#477)
peterdeme added a commit that referenced this pull request Feb 5, 2024
@peterdeme
Multi VCS (#477)
21f71a0
peterdeme added a commit that referenced this pull request Feb 5, 2024
@peterdeme @truszkowski
Multi VCS (#481)
fa45049 
* Multi VCS (#477)

* GitHub Integration: add missing webhook url

* GitHub Integration: add missing webhook url (update doc)

---------

Co-authored-by: Piotr Truszkowski <[email protected]>
truszkowski added a commit that referenced this pull request Mar 4, 2024
@peterdeme @truszkowski
Multi VCS (#481)
a52fd96 
* Multi VCS (#477)

* GitHub Integration: add missing webhook url

* GitHub Integration: add missing webhook url (update doc)

---------

Co-authored-by: Piotr Truszkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdeme