Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook_url to Bitbucket Cloud integration data source #484

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

mbialon
Copy link
Contributor

@mbialon mbialon commented Nov 23, 2023

Description of the change

Expose Bitbucket Cloud integration webhook URL.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@mbialon mbialon self-assigned this Nov 23, 2023
Signed-off-by: Marcin Białoń <[email protected]>
@mbialon mbialon changed the title Add webhook_url to spacelift_bitbucket_cloud_integration Add webhook_url to Bitbucket Cloud integration data-source Nov 23, 2023
@mbialon mbialon changed the title Add webhook_url to Bitbucket Cloud integration data-source Add webhook_url to Bitbucket Cloud integration data source Nov 23, 2023
@mbialon mbialon marked this pull request as ready for review November 23, 2023 15:53
@mbialon mbialon requested review from Yantrio, cube2222, tomasmik and a team November 23, 2023 15:54
@peterdeme
Copy link
Contributor

lgtm

@mbialon mbialon merged commit 0d6e7d6 into main Nov 27, 2023
7 checks passed
@mbialon mbialon deleted the add-bitbucket-cloud-webhook-url branch November 27, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants