Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add custom headers to audit trail #563

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

ilya-hontarau
Copy link
Contributor

@ilya-hontarau ilya-hontarau commented Aug 8, 2024

Description of the change

Reopen PR #556

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@ilya-hontarau ilya-hontarau requested review from adamconnelly and a team August 8, 2024 11:51
adamconnelly
adamconnelly previously approved these changes Aug 12, 2024
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just saw something in one of the field docs to tweak.

spacelift/resource_audit_trail_webhook.go Outdated Show resolved Hide resolved
@ilya-hontarau ilya-hontarau requested review from adamconnelly and a team August 12, 2024 11:09
@ilya-hontarau ilya-hontarau requested review from a team, eliecharra and tomasmik August 12, 2024 13:08
@ilya-hontarau ilya-hontarau merged commit 792c386 into main Aug 14, 2024
7 checks passed
@ilya-hontarau ilya-hontarau deleted the feature/add-custom-headers-to-audit-trail branch August 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants