-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vcs-aggregated-checks): exposes VCS checks settings in the available VCS integrations #566
Merged
silviutanasa
merged 7 commits into
main
from
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
Sep 3, 2024
Merged
feat(vcs-aggregated-checks): exposes VCS checks settings in the available VCS integrations #566
silviutanasa
merged 7 commits into
main
from
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviutanasa
force-pushed
the
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
branch
from
August 29, 2024 14:15
e805470
to
737c572
Compare
silviutanasa
force-pushed
the
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
branch
5 times, most recently
from
August 30, 2024 07:44
d2ddd91
to
c2e4f28
Compare
silviutanasa
force-pushed
the
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
branch
6 times, most recently
from
August 30, 2024 10:01
28b84d7
to
b619568
Compare
…able defined in the infra repo
silviutanasa
force-pushed
the
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
branch
from
August 30, 2024 11:04
b619568
to
5399f64
Compare
…Cloud integration
…terprise integration
silviutanasa
changed the title
feat(vcs-aggregated-checks): exposes VCS checks settings in Gitlab VC…
feat(vcs-aggregated-checks): exposes VCS checks settings in the available VCS integrations
Sep 2, 2024
mbialon
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mbialon
approved these changes
Sep 3, 2024
silviutanasa
deleted the
cu-8695g4h7c-expose-vcs-checks-setting-in-tf-provider
branch
September 3, 2024 12:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
New:
As part of the VCS Aggregated checks epic (https://app.clickup.com/t/8694knv2g), we added support, for the new "vcs_checks" option, to the existing VCS integrations from our terraform provider.
This change affects only the exiting supported VCS integrations terraform data and resources.
Feature demo: https://www.loom.com/share/4f1fad2530b846aa8d56d6b1d8151990
Improvements:
Because the "SPACELIFT_API_KEY_ENDPOINT" config key was using a Github secret, and because we don't consider it to be a sensitive value, for simplicity, we defined it in the infra repo and used it directly.
Caveats:
The VCS Aggregated checks is under a Feature flag, so exposing this option in the provider can cause issues to the clients that want to use it, but don't have the Feature flag enabled.
Type of change
Checklists
Development
false
.)go generate
to make sure the docs are up to dateCode review