Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement querying for spaces using relative paths #576

Merged
merged 13 commits into from
Nov 8, 2024

Conversation

TheMacies
Copy link
Contributor

@TheMacies TheMacies commented Oct 24, 2024

Description of the change

Currently spacelift_space_by_path data source only allows querying for spaces using full paths starting with root.
With this PR it will be possible to specify only a part of the path (not start it with root) in which case we will assume that we shall start the search from the space that the stack, the spacelift run is for, is in.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

adamconnelly
adamconnelly previously approved these changes Oct 24, 2024
docs/data-sources/space_by_path.md Outdated Show resolved Hide resolved
docs/data-sources/space_by_path.md Outdated Show resolved Hide resolved
@TheMacies TheMacies merged commit bce29ee into main Nov 8, 2024
7 checks passed
@TheMacies TheMacies deleted the relative-path-space branch November 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants