-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement querying for spaces using relative paths #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamconnelly
previously approved these changes
Oct 24, 2024
Co-authored-by: Adam Connelly <[email protected]>
Co-authored-by: Adam Connelly <[email protected]>
truszkowski
reviewed
Oct 29, 2024
…rm-provider-spacelift into relative-path-space
adamconnelly
approved these changes
Oct 29, 2024
truszkowski
approved these changes
Oct 30, 2024
…celift into relative-path-space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently
spacelift_space_by_path
data source only allows querying for spaces using full paths starting with root.With this PR it will be possible to specify only a part of the path (not start it with root) in which case we will assume that we shall start the search from the space that the stack, the spacelift run is for, is in.
Type of change
Development
false
.)go generate
to make sure the docs are up to dateCode review