fix: force new when the csr changes #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliecharra
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Good catch, thanks @Apollorion
Can you also update spacelift/resource_worker_pool_test.go to cover this new behavior with a test?
Apollorion
force-pushed
the
recreate-workerpool
branch
2 times, most recently
from
ed60d53 to
293afa5
Compare
Apollorion
force-pushed
the
recreate-workerpool
branch
from
293afa5 to
9a599f9
Compare
Apollorion
force-pushed
the
recreate-workerpool
branch
from
9a599f9 to
68a268a
Compare
eliecharra
approved these changes
Nov 18, 2024
peterdeme
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like theres no way to update the CSR after the workerpool has been created. We only set this value on create. We should force new resources if this value was to change. Its only comparing the CSR to state, so if someone was to update this today they'd think they made a change when they really didnt.