Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend context/label description, bump dependencies #586

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Nov 21, 2024

Description of the change

This is primarily @maxehio's contribution. 🙏 I added a few version bumps too.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@peterdeme peterdeme requested a review from a team November 21, 2024 17:07
@peterdeme peterdeme marked this pull request as ready for review November 21, 2024 17:07
@peterdeme peterdeme requested a review from maxehio November 21, 2024 17:07
@peterdeme peterdeme mentioned this pull request Nov 21, 2024
14 tasks
@peterdeme peterdeme merged commit f715e37 into main Nov 21, 2024
7 checks passed
@peterdeme peterdeme deleted the expand-resource-context-labels-description branch November 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants