Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about Kubernetes native workers #401

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Dec 4, 2023

Description of the change

I've added some info about how to install and configure the Spacelift workerpool operator for Kubernetes.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Dec 4, 2023

eliecharra
eliecharra previously approved these changes Dec 5, 2023
Copy link
Member

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could still reconvert to be an author the day software engineering will piss you off. This doc is great 👍🏻

@adamconnelly
Copy link
Contributor Author

You could still reconvert to be an author the day software engineering will piss you off. This doc is great 👍🏻

Thanks @eliecharra - you're too kind ❤️

@eliecharra
Copy link
Member

The controller has been released, I restarted the check so now it's ✅ .

@adamconnelly adamconnelly force-pushed the adamc/document-k8s-native-workers branch from eb89373 to 2c6b77b Compare December 6, 2023 15:17
@eliecharra eliecharra force-pushed the adamc/document-k8s-native-workers branch from 24e47b1 to d0dfd78 Compare January 12, 2024 15:08
@adamconnelly adamconnelly force-pushed the adamc/document-k8s-native-workers branch from d0dfd78 to c9511b3 Compare January 17, 2024 16:36
eminalemdar
eminalemdar previously approved these changes Jan 18, 2024
Copy link
Contributor

@eminalemdar eminalemdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eliecharra eliecharra force-pushed the adamc/document-k8s-native-workers branch from 02dfa02 to 5208547 Compare January 29, 2024 09:16
I've added some info about how to install and configure the Spacelift workerpool operator for Kubernetes.
@adamconnelly adamconnelly force-pushed the adamc/document-k8s-native-workers branch from 5208547 to aa84d9c Compare January 29, 2024 10:42
@adamconnelly adamconnelly marked this pull request as ready for review January 29, 2024 10:43
@adamconnelly adamconnelly merged commit e5ab2a9 into main Jan 29, 2024
1 check passed
@adamconnelly adamconnelly deleted the adamc/document-k8s-native-workers branch January 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants