Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two notes about workerpools and docker images #407

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Dec 7, 2023

Description of the change

I bumped into this issue where 2 customers didn't know any of this.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Dec 7, 2023

@peterdeme peterdeme requested a review from a team December 7, 2023 12:17
@peterdeme peterdeme force-pushed the two-small-callouts branch 2 times, most recently from f22c63e to 8e8dd48 Compare December 7, 2023 12:47
eliecharra
eliecharra previously approved these changes Dec 7, 2023
@peterdeme peterdeme merged commit 7fdb9a1 into main Dec 7, 2023
1 check passed
@peterdeme peterdeme deleted the two-small-callouts branch December 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants