Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bulk actions screenshots filenames #687

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

Roma36
Copy link
Contributor

@Roma36 Roma36 commented Dec 10, 2024

Description of the change

This PR is needed to prepare the grounds for screenshots generation using storybook.
No actual changes, just some file paths changed.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@Roma36 Roma36 requested a review from dnaploszek December 10, 2024 13:20
@adamconnelly adamconnelly temporarily deployed to change-bulk-actions-screenshots-filenames - spacelift-user-documentation PR #687 December 10, 2024 13:20 — with Render Destroyed
@Roma36 Roma36 requested a review from adamconnelly December 10, 2024 13:21
peterdeme
peterdeme previously approved these changes Dec 10, 2024
@adamconnelly adamconnelly temporarily deployed to change-bulk-actions-screenshots-filenames - spacelift-user-documentation PR #687 December 10, 2024 13:43 — with Render Destroyed
@Roma36 Roma36 merged commit 5eda6eb into main Dec 10, 2024
1 check failed
@Roma36 Roma36 deleted the change-bulk-actions-screenshots-filenames branch December 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants