[Merged by Bors] - Add Info request to post client #5186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5186 +/- ##
========================================
Coverage 77.6% 77.7%
========================================
Files 261 262 +1
Lines 30995 31145 +150
========================================
+ Hits 24083 24219 +136
- Misses 5406 5416 +10
- Partials 1506 1510 +4
|
4 tasks
poszu
approved these changes
Oct 23, 2023
|
bors merge |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
## Motivation Part of #5149 This extends the `PostClient` to be able to fetch metadata about the PoST from the service ## Changes - Add method to fetch metadata from PoST service ## Test Plan - Tests were added for new functionality with and without TLS ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
## Motivation Part of #5149 merge after #5186 & #5189 This moves the initialization code into the PoST supervisor. The ATX builder should not concern itself with initialization: - A remote PoST service that connects is expected to already be fully initialized - In supervised mode the supervisor takes care of initialization This allows to simplify the ATX builder, which has partially already been done in this PR and will continue in future PRs. ## Changes - Removed dependency on `postSetupManager` from `atxBuilder` - Simplified `atxBuilder` - Initial Proofs are not verified any more (PoST service is trusted) - Information about the PoST is fetched from the PoST service rather than accessed via the `postSetupManager` - Simplified `postSetupManager` - Since meta information is now fetched via the client everything besides `StartSession`, `StopSession` and `Reset` has been removed from the interface - `postSetupManager` isn't used by the gRPC `SmeshingService` any more, instead it's now used by `PostSupervisor` to init a supervised node before starting it For next PR: - change `atxBuilder` from `Start`/`Stop` to `Run` - a post service connecting triggers the builder loop (one per connected service) - simplify `atxBuilder` further and consider merging `nipostBuilder` into it. ## Test Plan - added new tests to PoST supervisor to cover new functionality - updated existing tests ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
## Motivation Part of #5149 merge after #5186 & #5189 This moves the initialization code into the PoST supervisor. The ATX builder should not concern itself with initialization: - A remote PoST service that connects is expected to already be fully initialized - In supervised mode the supervisor takes care of initialization This allows to simplify the ATX builder, which has partially already been done in this PR and will continue in future PRs. ## Changes - Removed dependency on `postSetupManager` from `atxBuilder` - Simplified `atxBuilder` - Initial Proofs are not verified any more (PoST service is trusted) - Information about the PoST is fetched from the PoST service rather than accessed via the `postSetupManager` - Simplified `postSetupManager` - Since meta information is now fetched via the client everything besides `StartSession`, `StopSession` and `Reset` has been removed from the interface - `postSetupManager` isn't used by the gRPC `SmeshingService` any more, instead it's now used by `PostSupervisor` to init a supervised node before starting it For next PR: - change `atxBuilder` from `Start`/`Stop` to `Run` - a post service connecting triggers the builder loop (one per connected service) - simplify `atxBuilder` further and consider merging `nipostBuilder` into it. ## Test Plan - added new tests to PoST supervisor to cover new functionality - updated existing tests ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #5149
This extends the
PostClientto be able to fetch metadata about the PoST from the serviceChanges
Test Plan
TODO