-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP: Move NiPoST state into db #5202
Conversation
8e7cf7c
to
8221bb1
Compare
5524478
to
1747cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think that this is a good idea. db stores generic data and can be copied to other machines safely right now. lets please preserve that
i suggest to keep several files. or if you really want, create another sqlite instance to store smesher specific data
The data added to the db is still safe to copy to another machine. The state is stored contains information about the node id and the publish epoch it belongs to -> another node with different identities will first ignore and later prune those when their publish epoch passes. ( The reason why I want to to get rid of the blob data on disk is because:
Some of the currently failing tests fail because the state that is loaded from disk hasn't been checked before - e.g. publish fails, time advances to next epoch, node retries and publishes ATX with same nipost again <- should in my opinion not happen, since public epoch passed already. EDIT: this could also be just a bug in my current implementation 😅 |
Superceded by #5207 |
Motivation
Closes #5206 - adds local db and moves nipost state into it
This is a prerequisite for making multiple identities possible with the ATX builder. The state that is persisted by the
activation.Builder
andactivation.NIPostBuilder
is moved into the DB.Changes
nipost
tableactivation.Builder
to use new source for stateTest Plan
TODO