[Merged by Bors] - Remove obsolete log package functions #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6252 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 308 308
Lines 34121 34087 -34
=========================================
- Hits 28019 27983 -36
- Misses 4330 4335 +5
+ Partials 1772 1769 -3 ☔ View full report in Codecov by Sentry. |
tryBuild failed: |
fasmat
force-pushed
the
remove-obsolete-log-package-functions
branch
from
af47638 to
36a7005
Compare
|
bors try |
tryBuild failed: |
poszu
approved these changes
Aug 14, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Motivation This is another step in the gradual removal of the `log` package from the node. Many now unused functions were removed.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Motivation This is another step in the gradual removal of the `log` package from the node. Many now unused functions were removed.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
4 tasks
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Motivation Follow up to this discussion: #6252 (comment) Removal of the global logger from (most of) the event package.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Motivation Follow up to this discussion: #6252 (comment) Removal of the global logger from (most of) the event package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is another step in the gradual removal of the
logpackage from the node. Many now unused functions were removed.Description
Removed functionality from the
logpackage that isn't used any more and refactored code a bit to not use globals any more (e.g.log.Json(true)). The global logger isn't fully removed yet, since it is still used in some places.Test Plan
TODO