Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-split: add smeshing identities endpoint to smesher service PoC #6452
node-split: add smeshing identities endpoint to smesher service PoC #6452
Changes from 5 commits
7ec1727
11c94d6
3173a03
2cd426a
debdbb3
5c7d3cd
be6c4b1
5e802e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 518 in activation/activation.go
activation/activation.go#L517-L518
Check warning on line 70 in activation/identity_states.go
activation/identity_states.go#L43-L70
Check warning on line 113 in activation/identity_states.go
activation/identity_states.go#L112-L113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to use something like a ring buffer to avoid reallocating the slice repeatedly (when the append below exceeds the capacity).
Check warning on line 131 in activation/identity_states.go
activation/identity_states.go#L123-L131
Check warning on line 137 in activation/identity_states.go
activation/identity_states.go#L134-L137
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.