Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache beacons per epoch to avoid repeated queries to node service #6679

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jan 31, 2025

Part of #6676

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (d4b6405) to head (6045b8d).
Report is 5 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
hare3/remote.go 0.0% 5 Missing ⚠️
node/smeshing_service.go 0.0% 4 Missing ⚠️
api/node/models/models.go 0.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           node-split-poc   #6679   +/-   ##
==============================================
  Coverage            77.0%   77.1%           
==============================================
  Files                 385     386    +1     
  Lines               53652   53660    +8     
==============================================
+ Hits                41357   41411   +54     
+ Misses               9824    9786   -38     
+ Partials             2471    2463    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/node/models/models.go Outdated Show resolved Hide resolved
beacon/cached_provider_test.go Outdated Show resolved Hide resolved
hare3/remote.go Show resolved Hide resolved
beacon/cached_provider_test.go Outdated Show resolved Hide resolved
@poszu poszu force-pushed the node-split-optimize-beacon-queries branch from 4f5f69a to 6045b8d Compare February 3, 2025 14:36
@poszu poszu merged commit 99e49c9 into node-split-poc Feb 3, 2025
13 checks passed
@poszu poszu deleted the node-split-optimize-beacon-queries branch February 3, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants