-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate system tests to use GRPC V2 API #6696
base: develop
Are you sure you want to change the base?
Conversation
bors try |
tryBuild failed: |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6696 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.1%
=========================================
Files 366 366
Lines 50006 50005 -1
=========================================
- Hits 39941 39936 -5
- Misses 7799 7801 +2
- Partials 2266 2268 +2 ☔ View full report in Codecov by Sentry. |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
15e6bcc
to
174c4f7
Compare
174c4f7
to
63d37de
Compare
Motivation
System tests still use the v1 API. I migrated the tests to instead use the V2 API where possible.
Closes #6692
TODO: there appear to be issues with the v2beta1 and v2alpha1 APIs regarding streaming of layers. To avoid putting too much effort into this I'll put this into draft for now and will take another look later.
Description
All tests where migrated to use v2 APIs over v1 APIs. The only requests not yet migrated are proposal streams since those aren't available in v2 (and probably won't ever be). We should consider implementing those tests in a different way.
Additionally I moved the v1 API into its own package
api/grpcserver/v1
instead of having it in the sharedapi/grpcserver
package. This will make it easier in the future to deprecate / remove this code.Test Plan
All system tests still pass as before.
TODO