Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate system tests to use GRPC V2 API #6696

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Feb 5, 2025

Motivation

System tests still use the v1 API. I migrated the tests to instead use the V2 API where possible.

Closes #6692

TODO: there appear to be issues with the v2beta1 and v2alpha1 APIs regarding streaming of layers. To avoid putting too much effort into this I'll put this into draft for now and will take another look later.

Description

All tests where migrated to use v2 APIs over v1 APIs. The only requests not yet migrated are proposal streams since those aren't available in v2 (and probably won't ever be). We should consider implementing those tests in a different way.

Additionally I moved the v1 API into its own package api/grpcserver/v1 instead of having it in the shared api/grpcserver package. This will make it easier in the future to deprecate / remove this code.

Test Plan

All system tests still pass as before.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Feb 5, 2025
@fasmat
Copy link
Member Author

fasmat commented Feb 5, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 5, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 5, 2025

try

Build failed:

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 41.07143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 79.8%. Comparing base (20fd927) to head (63d37de).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/grpcserver/v2alpha1/layer.go 25.0% 14 Missing and 1 partial ⚠️
api/grpcserver/v2beta1/layer.go 25.0% 14 Missing and 1 partial ⚠️
sql/layers/layers.go 0.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6696     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.1%     
=========================================
  Files          366     366             
  Lines        50006   50005      -1     
=========================================
- Hits         39941   39936      -5     
- Misses        7799    7801      +2     
- Partials      2266    2268      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member Author

fasmat commented Feb 5, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 5, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 5, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 6, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 6, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 6, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 6, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 6, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 6, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 6, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 6, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 6, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 6, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Feb 6, 2025

try

Build failed:

@fasmat fasmat marked this pull request as draft February 7, 2025 11:41
@fasmat fasmat force-pushed the migrate-systest-grpc-version branch from 15e6bcc to 174c4f7 Compare February 7, 2025 11:43
@fasmat fasmat force-pushed the migrate-systest-grpc-version branch from 174c4f7 to 63d37de Compare February 7, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update system test to use v2beta1 GRPC api instead of v1
1 participant