Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Upgrade to go 1.24 #6722

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - Upgrade to go 1.24 #6722

wants to merge 20 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Feb 13, 2025

Motivation

This updates our codebase to go 1.24

Description

  • upgraded go.mod to select for go 1.24
  • fixed new issues found in the codebase:
    • use t.Context() in tests
    • remove unused interfaces
    • detect always nil errors
  • upgraded old-smesher build to latest release

Test Plan

existing unit and system tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Feb 13, 2025
@fasmat
Copy link
Member Author

fasmat commented Feb 13, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.8%. Comparing base (91ba3fb) to head (04b101e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6722     +/-   ##
=========================================
- Coverage     76.8%   76.8%   -0.1%     
=========================================
  Files          369     369             
  Lines        50283   50285      +2     
=========================================
- Hits         38665   38657      -8     
- Misses        9410    9417      +7     
- Partials      2208    2211      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Feb 13, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Feb 13, 2025
@spacemesh-bors
Copy link

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Mar 4, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Mar 4, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Mar 4, 2025

try

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Mar 5, 2025

bors try

spacemesh-bors bot added a commit that referenced this pull request Mar 5, 2025
@spacemesh-bors
Copy link

spacemesh-bors bot commented Mar 5, 2025

try

Build succeeded:

@fasmat fasmat marked this pull request as ready for review March 5, 2025 16:10
@fasmat fasmat requested a review from poszu March 5, 2025 19:47
@fasmat
Copy link
Member Author

fasmat commented Mar 6, 2025

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Mar 6, 2025
## Motivation

This updates our codebase to go 1.24
@spacemesh-bors
Copy link

spacemesh-bors bot commented Mar 6, 2025

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Upgrade to go 1.24 [Merged by Bors] - Upgrade to go 1.24 Mar 6, 2025
@spacemesh-bors spacemesh-bors bot closed this Mar 6, 2025
@spacemesh-bors spacemesh-bors bot deleted the test-go-1.24 branch March 6, 2025 12:27
@fasmat fasmat mentioned this pull request Mar 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants