feat: add default networks #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview the changes at : https://3c728b0e.smapp-lite-prod.pages.dev |
brusherru
force-pushed
the
add-default-networks
branch
from
e455c1d to
e9d8417
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
You can preview the changes at : https://fdeae6bf.smapp-lite-prod.pages.dev |
pigmej
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two default networks in the list:
This networks won't be stored in the localStorage, so they might be replaced easily in the future (TestNet).
And it is still possible to add custom networks and switch between them.
The only possible bad edge case — if we remove testnet / add one more network — it may switch to this network automatically (because selected index is stored in the localstorage, while default networks are indexed all together).
But anyway, I believe it will make easier to check out the wallet by testers ;)
P.S.
It is based on top of PR #23, so it includes all previous fixes.