Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show "Unknown fee" if tx published before got response from API #32

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

brusherru
Copy link
Member

@dioexul found and issue:
When User submits a transaction before got response from EstimateGas endpoint, app crashes with an error.
With this fix in such a case "Unknown fee" will be displayed and later replaced with an actual one.

How to reproduce / test

  1. Prepare the transaction, but before clicking on "Next" button turn off the internet (you can use Throttling feature in developer tools on the network tab).
  2. Click "Next" and then click "Sign & Publish"
  3. Type the password in BUT don't publish yet
  4. Turn on internet (you may switch "No internet" to "Slow 3G" in throttling dropdown)
  5. And then click on Publish button quickly (to publish it before EstimateGas API will respond)

@brusherru brusherru self-assigned this Jul 11, 2024
Copy link

You can preview the changes at : https://11171592.smapp-lite-prod.pages.dev

@brusherru brusherru merged commit 6b443ab into main Jul 11, 2024
1 check passed
@brusherru brusherru deleted the fix-no-fee branch July 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant