Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "comment post" button which expands the post reply textarea #179

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add "comment post" button which expands the post reply textarea #179

wants to merge 1 commit into from

Conversation

Aivean
Copy link
Collaborator

@Aivean Aivean commented Nov 13, 2022

Demo:
orb-comm

The top button is hidden when there are no comments:
orb-comm2

pazoozoo42
pazoozoo42 reviewed Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@pazoozoo42 pazoozoo42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is ok, but I don't understand which problem this PR is fixing?

Also, when the post is empty there are 3 similar labels about commenting and clicking the top one does nothing:

image

@Aivean
Copy link
Collaborator Author

Aivean commented Nov 13, 2022

Code is ok, but I don't understand which problem this PR is fixing?

It addresses two problems:

  1. Users often confuse the textarea in the bottom of the post with the comment reply textarea. That happens when the comment they are replying to is the last one in the post (happened to me once).
  2. There was a request for a way to add a comment without manually scrolling to the bottom.

Also, when the post is empty there are 3 similar labels about commenting and clicking the top one does nothing:

I also don't like the top button very much. Perhaps @ArtCraft has some comment on that?

@Aivean Aivean added this to the Release 2.1.0 milestone Nov 21, 2022
@Aivean Aivean modified the milestones: Release 3.0.0, 4.0.0 Dec 13, 2022
@Aivean Aivean marked this pull request as draft December 27, 2022 02:03
@Aivean Aivean removed this from the 4.0.0 milestone Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazoozoo42 pazoozoo42 pazoozoo42 left review comments

@ArtCraft ArtCraft Awaiting requested review from ArtCraft

@4vanger 4vanger Awaiting requested review from 4vanger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aivean @pazoozoo42